All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-xfs@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Carlos  Maiolino <cem@kernel.org>, Christoph Hellwig <hch@lst.de>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: [PATCH 04/14] xfs: Remove unused event xfs_ioctl_clone
Date: Thu, 12 Jun 2025 17:24:09 -0400	[thread overview]
Message-ID: <20250612212635.247519894@goodmis.org> (raw)
In-Reply-To: 20250612212405.877692069@goodmis.org

From: Steven Rostedt <rostedt@goodmis.org>

The trace event xfs_ioctl_clone was added but never used. As trace events
can take up to 5K of memory in text and meta data regardless if they are
used or not, remove the unused trace event.

Fixes: 53aa1c34f4eb ("xfs: define tracepoints for reflink activities")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/xfs/xfs_trace.h | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 049bf9e34063..ad686fe0a577 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -4210,32 +4210,6 @@ DEFINE_INODE_IREC_EVENT(xfs_reflink_remap_extent_dest);
 DEFINE_DOUBLE_IO_EVENT(xfs_reflink_compare_extents);
 DEFINE_INODE_ERROR_EVENT(xfs_reflink_compare_extents_error);
 
-/* ioctl tracepoints */
-TRACE_EVENT(xfs_ioctl_clone,
-	TP_PROTO(struct inode *src, struct inode *dest),
-	TP_ARGS(src, dest),
-	TP_STRUCT__entry(
-		__field(dev_t, dev)
-		__field(unsigned long, src_ino)
-		__field(loff_t, src_isize)
-		__field(unsigned long, dest_ino)
-		__field(loff_t, dest_isize)
-	),
-	TP_fast_assign(
-		__entry->dev = src->i_sb->s_dev;
-		__entry->src_ino = src->i_ino;
-		__entry->src_isize = i_size_read(src);
-		__entry->dest_ino = dest->i_ino;
-		__entry->dest_isize = i_size_read(dest);
-	),
-	TP_printk("dev %d:%d ino 0x%lx isize 0x%llx -> ino 0x%lx isize 0x%llx",
-		  MAJOR(__entry->dev), MINOR(__entry->dev),
-		  __entry->src_ino,
-		  __entry->src_isize,
-		  __entry->dest_ino,
-		  __entry->dest_isize)
-);
-
 /* unshare tracepoints */
 DEFINE_SIMPLE_IO_EVENT(xfs_reflink_unshare);
 DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error);
-- 
2.47.2



  parent reply	other threads:[~2025-06-12 21:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 21:24 [PATCH 00/14] xfs: Remove unused trace events Steven Rostedt
2025-06-12 21:24 ` [PATCH 01/14] xfs: tracing; Remove unused event xfs_reflink_cow_found Steven Rostedt
2025-06-13 15:38   ` Steven Rostedt
2025-06-13 23:52   ` kernel test robot
2025-06-12 21:24 ` [PATCH 02/14] xfs: Remove unused trace event xfs_attr_remove_iter_return Steven Rostedt
2025-06-16  5:26   ` Christoph Hellwig
2025-06-16 14:51     ` Steven Rostedt
2025-06-12 21:24 ` [PATCH 03/14] xfs: Remove unused event xlog_iclog_want_sync Steven Rostedt
2025-06-12 21:24 ` Steven Rostedt [this message]
2025-06-12 21:24 ` [PATCH 05/14] xfs: Remove unused xfs_reflink_compare_extents events Steven Rostedt
2025-06-12 21:24 ` [PATCH 06/14] xfs: Remove unused trace event xfs_attr_rmtval_set Steven Rostedt
2025-06-12 21:24 ` [PATCH 07/14] xfs: ifdef out unused xfs_attr events Steven Rostedt
2025-06-16  5:28   ` Christoph Hellwig
2025-06-16 14:52     ` Steven Rostedt
2025-06-17  4:46       ` Christoph Hellwig
2025-06-12 21:24 ` [PATCH 08/14] xfs: Remove unused event xfs_attr_node_removename Steven Rostedt
2025-06-12 21:24 ` [PATCH 09/14] xfs: Remove unused event xfs_alloc_near_error Steven Rostedt
2025-06-12 21:24 ` [PATCH 10/14] xfs: Remove unused event xfs_alloc_near_nominleft Steven Rostedt
2025-06-12 21:24 ` [PATCH 11/14] xfs: Remove unused event xfs_pagecache_inval Steven Rostedt
2025-06-12 21:24 ` [PATCH 12/14] xfs: Remove usused xfs_end_io_direct events Steven Rostedt
2025-06-12 21:24 ` [PATCH 13/14] xfs: Only create event xfs_file_compat_ioctl when CONFIG_COMPAT is configure Steven Rostedt
2025-06-12 21:24 ` [PATCH 14/14] xfs: Change xfs_xattr_class from a TRACE_EVENT() to DECLARE_EVENT_CLASS() Steven Rostedt
2025-06-13 15:08 ` [PATCH 00/14] xfs: Remove unused trace events Darrick J. Wong
2025-06-13 15:31   ` Steven Rostedt
2025-06-16  5:31     ` Christoph Hellwig
2025-06-16 14:58       ` Steven Rostedt
2025-07-23 22:35   ` Steven Rostedt
2025-06-16  5:30 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250612212635.247519894@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.