From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D30C2C71135 for ; Fri, 13 Jun 2025 09:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TzL1Eh+MsgVfYsmxUvOb7TMeCHldVLZWaEJvZ5p/uVA=; b=lFKkOVyaDtD2Pr iir7NAvX0/PKpCIqcmKj5gdqIybHfemXgKoI0gINOB42/Np8ilduSzrGXnJZktuSztVJkEaJcjNvW 3WNROJqR2qbm5QUL4Dw1tW9eE2G9BhXUWusFWGZ2Es8QBVkyKk+i/ii5Vd00DZDSYE3AYS4o84zYH fwAWCil/ZScg0MNpdcndA0IRit8KW0MZ4/1IkTb2EuBXvFuVrtdvXLoUm1WKuNU72dHTIp3aEzF/D OzPV3HeeIAKgpOEpDsixmUsJjk0G5P3b6fpFT3vWoBbTgX0CyiQc3tu3vlkagPav+D+3SV51292vH wEhROlFy/WZcXXpgNo0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ0vF-0000000Fw7j-3bD8; Fri, 13 Jun 2025 09:42:07 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPyMl-0000000FXRh-02G2 for kvm-riscv@lists.infradead.org; Fri, 13 Jun 2025 06:58:20 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-31329098ae8so1578362a91.1 for ; Thu, 12 Jun 2025 23:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1749797898; x=1750402698; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vPp46eZSp7JL4MdOWPUs+dW6gfTxSrmGdnYXz+FMAYQ=; b=Fg7F88hlgQTX7480gcqGKFB0cwzcul6ElaZuwEaJpPjHY43ssGtkV92RVManonQpDl A7on6F/lAcK3+7Aky592hljyNVH8CPP8UB4IsCnK5Pl0xEC+PYWr60Z3IHYomiUJZblC qiI+8+MBupv9xqAE/f5kmFXTovGjTQSj1oB2POS7OMgjtJp4P35Ft7QjqaXVyXMl+nVw eh2rTT9gzCvhrl4Qp69HF0onO4cqgzvOy89Y1H/CEcYfkIPTLlvqHYAEBCShQHf00ivw 1ebnwR+J9qYEkp0f38KbmalauTSuWaLUzqksFWhvJ+8qKYplTCUSM9Pq0fUnzADH99Sk kb4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749797898; x=1750402698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vPp46eZSp7JL4MdOWPUs+dW6gfTxSrmGdnYXz+FMAYQ=; b=l0urjIZfpf6h5czOLRUOnKIKGK7WMEBBf2IokKhkuI0ORmqRwyhC3vo3/iQw7xVtcj Pdy/etVjSK/C24zrw8Lk/uMoePMvZJATK6zdmY1dcNYyimwWdbiJV5NFLBKAx+XP2Avs kjN+TZU3Bsawjtz2z/p3cvlI4GkgLUEA1NcGX9I/AJzkZi9G0gy3j8CAiYHiO47i/PHR veoW0HkcaEZYJe54R9AQd9jRWtQ2KOEmUaSDbz5ecO18v+5linAc0571tJezrofPj7T2 lNaHdso5IBHOpHaoET1+fgeqEccg5YS6lKuUcIPnaMvXyXaTLOXlQwBebtQ+oJ02MTbB CkUg== X-Forwarded-Encrypted: i=1; AJvYcCUugwspzyeGEVyQ0YFePgP5bV184BvR+rnTegYzdBm3txg4GzrwhzeO1wv3bM8tFdvijneoHc2o2rE=@lists.infradead.org X-Gm-Message-State: AOJu0YwdZGdmGkhOPMrWmzZLFQR56QDJhPJwcb04an2kw+C90KE6CrEE Uet16JvpDJCGgAJogqFJbLtsWCyTxOTIG0mW6P6wSlqxPgslFiZEuhSJTZ3Le3Azrlc= X-Gm-Gg: ASbGnctenL/hhUATDN/Bp6EaZOUIN6qL7YSgscQvENwzh8kHpAGY9HrbB47ERax1ahL bt7/K/1a7MfC5iUU8fSfnz2X7xSwuwK5Fbu8qg+yYfguLWa8hP1+i9hrMLS5W2XczIFjS+65JeB RLs+ePaHG9e4OzeR7CEu0AaoGlsKdPlnCkupmHSd6GcuYqcvHhAixHAj1hitDnfuuTElISlefFf vJDkOZ4tyrMqKvceyQqhzXXDOEOMj0mqd/rr4kVr8gBaN2mlZq6ML8+BiEneXFUciMHy8jnjIjN t2oyn+ug8/s/4QvYuD8gQ8Px/LjZGMcFiOC5qOCNmjfz0zPM+OHtK3hXnmBPqoUhZIyTWpEds6Z T8OQdDI/9mLuub2WVIVo= X-Google-Smtp-Source: AGHT+IHlesOh77cakTH2YhHv43j8zOza0rZEzGZ+37qo1i6wlvyL7TrOfPOjUkpSesJgnyG08PjCmA== X-Received: by 2002:a17:90b:1256:b0:311:abba:53b6 with SMTP id 98e67ed59e1d1-313dc25631cmr1682026a91.14.1749797897914; Thu, 12 Jun 2025 23:58:17 -0700 (PDT) Received: from localhost.localdomain ([103.97.166.196]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-313c1b49b7fsm2653022a91.24.2025.06.12.23.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 23:58:17 -0700 (PDT) From: Anup Patel To: Atish Patra Cc: Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Andrew Jones , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel Subject: [PATCH v2 05/12] RISC-V: KVM: Don't flush TLB when PTE is unchanged Date: Fri, 13 Jun 2025 12:27:36 +0530 Message-ID: <20250613065743.737102-6-apatel@ventanamicro.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613065743.737102-1-apatel@ventanamicro.com> References: <20250613065743.737102-1-apatel@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250612_235819_052114_C114C841 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org The gstage_set_pte() and gstage_op_pte() should flush TLB only when a leaf PTE changes so that unnecessary TLB flushes can be avoided. Signed-off-by: Anup Patel --- arch/riscv/kvm/mmu.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c index 1087ea74567b..29f1bd853a66 100644 --- a/arch/riscv/kvm/mmu.c +++ b/arch/riscv/kvm/mmu.c @@ -167,9 +167,11 @@ static int gstage_set_pte(struct kvm *kvm, u32 level, ptep = &next_ptep[gstage_pte_index(addr, current_level)]; } - set_pte(ptep, *new_pte); - if (gstage_pte_leaf(ptep)) - gstage_remote_tlb_flush(kvm, current_level, addr); + if (pte_val(*ptep) != pte_val(*new_pte)) { + set_pte(ptep, *new_pte); + if (gstage_pte_leaf(ptep)) + gstage_remote_tlb_flush(kvm, current_level, addr); + } return 0; } @@ -229,7 +231,7 @@ static void gstage_op_pte(struct kvm *kvm, gpa_t addr, pte_t *ptep, u32 ptep_level, enum gstage_op op) { int i, ret; - pte_t *next_ptep; + pte_t old_pte, *next_ptep; u32 next_ptep_level; unsigned long next_page_size, page_size; @@ -258,11 +260,13 @@ static void gstage_op_pte(struct kvm *kvm, gpa_t addr, if (op == GSTAGE_OP_CLEAR) put_page(virt_to_page(next_ptep)); } else { + old_pte = *ptep; if (op == GSTAGE_OP_CLEAR) set_pte(ptep, __pte(0)); else if (op == GSTAGE_OP_WP) set_pte(ptep, __pte(pte_val(ptep_get(ptep)) & ~_PAGE_WRITE)); - gstage_remote_tlb_flush(kvm, ptep_level, addr); + if (pte_val(*ptep) != pte_val(old_pte)) + gstage_remote_tlb_flush(kvm, ptep_level, addr); } } -- 2.43.0 -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E17BF25D54A for ; Fri, 13 Jun 2025 06:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749797900; cv=none; b=Fsq3ZZ6sTt2crm7G79/cY2IZTynm2Tcaqfpr8qXPSoYR2AFL1Ffndj2hDiJMGQP+c4vDoJ3gjlGu35tr8U80AtQ2NJ53mUBr1HeG7VVxokoMsNVzxcM+813EH/py/mpvyaeqyGVj/Ioe3Vkw7I9xZp0svyTBwWy27C07f5LYXV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749797900; c=relaxed/simple; bh=N1Q7Yyxv25kh8YbbPEq1f4Xpl9cPz/xmC60ZF02nnis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YeKyZqq/VzE8hHUU9K4lQhzLn9TiMqsolDgHfZ7vAShNHdU0LVddpJbTvqe2quEEs1XtevDoDFt9dqSg+3FhpLSuNVsnHm+W6oe2AqOzbL7DltRf90e+TQPr2xE+dXFwjuJ1d844PyJhK6/03GwbtB2Uuzsnd4/4jTzatsX6fQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=JhBtF9N2; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="JhBtF9N2" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-31329098ae8so1578363a91.1 for ; Thu, 12 Jun 2025 23:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1749797898; x=1750402698; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vPp46eZSp7JL4MdOWPUs+dW6gfTxSrmGdnYXz+FMAYQ=; b=JhBtF9N2FLyRy6kJaLSipSLeBzJr5/v+eVEOXiOAbvdrDeLkZaVgOe/lUcT1Ddl9vn yU/NZ09DuwNG3J3DcJkbMXinrYUpS1+my77++y8hgOE4TWf888P5nYp66mvW3VPPZsw5 /EuM67m06U4zQzH2nq/boh3UQR+S4XTfGBhMdJRkxMryrHRkiNi6bWLXP0ChiBqeQ2Xj I2s17Si7ezP9oJWc5Bz+/5hswj7XoIFSDMDFtpxPeXoReOcpN2q0ZCzkqazVlWkVVjX1 eVja8zu9IwoCc36OXYmoaOGuVxfYuOmL6WSB8ahr1aJaKlJeooFOi6dkddwYLj08+ARQ YY0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749797898; x=1750402698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vPp46eZSp7JL4MdOWPUs+dW6gfTxSrmGdnYXz+FMAYQ=; b=WsLZn8WTiCUTVYMNW3CZsyMZNk2E4hjkJ7j263ZfOyYzr45XibK9KT7X1Muu6TgVQ3 KN5FPgZaXTxv1PbzU21VPeQmWyp3kPouikKWbIsFN7Y6mHFY0SuMAdS0atptmYGYwfMr 2tVxRdJcLiZUcC9cJ2n6LkxrfndGd5pl2CoeN8M+yz37qs1TGz6KPSzXzhJhRWweEX06 UNrrC9/YGQQ8WGkKBTUqd8S3CevB53l/Cu3Wg39urkrlB6o3UlNUgtKuEp1cnMAcuL4Q v3rjKw2ZzQzkq0sG7STjr2tCpAxg7ZnAlj4KNCGVAzpuPTdXTnqFBTXyuzjDSs83Evyf 5oyg== X-Forwarded-Encrypted: i=1; AJvYcCUBcuI7j5AH0JbZPJ7q3QRk9mpkIiW8Cd3LtkdAq80oaQyU5YG4Wom1Fns8BbOQ0l0Kq98=@vger.kernel.org X-Gm-Message-State: AOJu0YzM5MMQK1QgoiMQLhJAttHK4MaoQuam3kX68X3Tdiox7xmKhJ8Z qLrH7pZ6Xu/5c9YmYG5sSUhQwW47dsN1Irdip7v67W6BoAmTTWeiqXV6zewHK3pOSJs= X-Gm-Gg: ASbGncviDTN8JIkmvH/pLd2TotJwn7RaNMbpOY56PGrhrkLIydlYn4y6gc3NQi0Yjk3 QrAmkPqGCzZvzTPqF9lFnCn/qfh0sAltHNeLPa8io4QYpDSOv5f4gBdx3UN9s6OnUOr7N11PF9b CiskCYDI+ZA1ADKPuv7InNJbv5pMNYdzpZHO7NS37be3PhhIHFf5rNnOB+zyK+VkYEcly/3Qg+g 9t98+AiTHzPqv3YApVMnxOsQdItvKdqDGveg7+FgVa7+nUCV0KpDuhl10KnHmydGYuERtp0djAD ue+E2kgZUqiVZ0Y4Ef+ayCXWHmlS1mflL0Y1sLsvEEcG5crf6t9poYpiy5MoE7sv7PF9gPYKRXG nes0bF0SzGRIYWIvA/r8= X-Google-Smtp-Source: AGHT+IHlesOh77cakTH2YhHv43j8zOza0rZEzGZ+37qo1i6wlvyL7TrOfPOjUkpSesJgnyG08PjCmA== X-Received: by 2002:a17:90b:1256:b0:311:abba:53b6 with SMTP id 98e67ed59e1d1-313dc25631cmr1682026a91.14.1749797897914; Thu, 12 Jun 2025 23:58:17 -0700 (PDT) Received: from localhost.localdomain ([103.97.166.196]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-313c1b49b7fsm2653022a91.24.2025.06.12.23.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 23:58:17 -0700 (PDT) From: Anup Patel To: Atish Patra Cc: Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Andrew Jones , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel Subject: [PATCH v2 05/12] RISC-V: KVM: Don't flush TLB when PTE is unchanged Date: Fri, 13 Jun 2025 12:27:36 +0530 Message-ID: <20250613065743.737102-6-apatel@ventanamicro.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613065743.737102-1-apatel@ventanamicro.com> References: <20250613065743.737102-1-apatel@ventanamicro.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The gstage_set_pte() and gstage_op_pte() should flush TLB only when a leaf PTE changes so that unnecessary TLB flushes can be avoided. Signed-off-by: Anup Patel --- arch/riscv/kvm/mmu.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c index 1087ea74567b..29f1bd853a66 100644 --- a/arch/riscv/kvm/mmu.c +++ b/arch/riscv/kvm/mmu.c @@ -167,9 +167,11 @@ static int gstage_set_pte(struct kvm *kvm, u32 level, ptep = &next_ptep[gstage_pte_index(addr, current_level)]; } - set_pte(ptep, *new_pte); - if (gstage_pte_leaf(ptep)) - gstage_remote_tlb_flush(kvm, current_level, addr); + if (pte_val(*ptep) != pte_val(*new_pte)) { + set_pte(ptep, *new_pte); + if (gstage_pte_leaf(ptep)) + gstage_remote_tlb_flush(kvm, current_level, addr); + } return 0; } @@ -229,7 +231,7 @@ static void gstage_op_pte(struct kvm *kvm, gpa_t addr, pte_t *ptep, u32 ptep_level, enum gstage_op op) { int i, ret; - pte_t *next_ptep; + pte_t old_pte, *next_ptep; u32 next_ptep_level; unsigned long next_page_size, page_size; @@ -258,11 +260,13 @@ static void gstage_op_pte(struct kvm *kvm, gpa_t addr, if (op == GSTAGE_OP_CLEAR) put_page(virt_to_page(next_ptep)); } else { + old_pte = *ptep; if (op == GSTAGE_OP_CLEAR) set_pte(ptep, __pte(0)); else if (op == GSTAGE_OP_WP) set_pte(ptep, __pte(pte_val(ptep_get(ptep)) & ~_PAGE_WRITE)); - gstage_remote_tlb_flush(kvm, ptep_level, addr); + if (pte_val(*ptep) != pte_val(old_pte)) + gstage_remote_tlb_flush(kvm, ptep_level, addr); } } -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AAD0C71148 for ; Fri, 13 Jun 2025 11:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eipI2HY51zs8Wct1yCT3RiSatqL0qe7gW3FkQb2hlfM=; b=irOzZQdEB3hgAK 5nzs4tURugk4jiWPQDn8P9OqSK7+RUuyh08Ea3qopsVkQ/cdW2Mhct4fghAM3bSLj/lZUV4fOJl15 Y0+3GvP+bqNRWgwMVsbzFI+iLL5WU+Rk++Vrv7xTdQbOTZqA6EdArWFuTuDWfVRrbNqSHlipM4dxA JaTb66oi7Wx+VzJuvtX1kYAFF3IRcdKYlS5oesNgfooZltD9wflwcypGCKKvvdejfZQm+x5qft+hs jc3BNX6PKsZJSWJ/dCFHOt1cE+VJ2QZdC/SQspDz0X7V6+xlTUsV/rUdy9d6aNqiSwTsLQV/nXfx3 d45e80h7CsP1vpCLIdAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ2cD-0000000GAV4-1WRq; Fri, 13 Jun 2025 11:30:33 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPyMl-0000000FXRg-02BD for linux-riscv@lists.infradead.org; Fri, 13 Jun 2025 06:58:20 +0000 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-b2fb8226e1cso2843107a12.0 for ; Thu, 12 Jun 2025 23:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1749797898; x=1750402698; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vPp46eZSp7JL4MdOWPUs+dW6gfTxSrmGdnYXz+FMAYQ=; b=Fg7F88hlgQTX7480gcqGKFB0cwzcul6ElaZuwEaJpPjHY43ssGtkV92RVManonQpDl A7on6F/lAcK3+7Aky592hljyNVH8CPP8UB4IsCnK5Pl0xEC+PYWr60Z3IHYomiUJZblC qiI+8+MBupv9xqAE/f5kmFXTovGjTQSj1oB2POS7OMgjtJp4P35Ft7QjqaXVyXMl+nVw eh2rTT9gzCvhrl4Qp69HF0onO4cqgzvOy89Y1H/CEcYfkIPTLlvqHYAEBCShQHf00ivw 1ebnwR+J9qYEkp0f38KbmalauTSuWaLUzqksFWhvJ+8qKYplTCUSM9Pq0fUnzADH99Sk kb4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749797898; x=1750402698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vPp46eZSp7JL4MdOWPUs+dW6gfTxSrmGdnYXz+FMAYQ=; b=YQDVmx7BXB3aL4h+x+cdCkwjZxIpYyl7O6ybndG7KCOpAV+fo2SDsr4Ok3HmjsFjRC rB9nJsdlyCym4HHwUTotLK07QVNQi2SjdrCRmYdFymlJxXD33VlNoDz2eHMrLUKKCsII mCus69KXwhSgECqsZ9L9tiPc+Sb2BfJ70Dh/SHoGhlTezkF8oG+jhHfLCEgz3gv3Svqx wDscgFPzk7C72VbO8coLP2I0cX9geCCfvWGvGKJLe+sAytFNQ/tYW+psjypjbiO523IK VYetNOLbi6e7k7iPMrS8LywTJeYvYooqx3YYH/82ZYnQXAP+i112o+eUMf4p4qBGxVjQ OCrg== X-Forwarded-Encrypted: i=1; AJvYcCVrER6l6+Rv2JInzgMwY8nRZYcnBZi/micG2kw8s5YgkhKVtOkwASb3UKV69n3FcRN/cd+gAlALlLYwrQ==@lists.infradead.org X-Gm-Message-State: AOJu0YyxHkVHWg2oRus+Wqi0nPPv+WRX2xPkI0k9aGf5xzUU2LutYppY Yhktt1Oy9dtp9CKAHF2Mr78Oa5qkFMXNJY+FiQlg4VU4tTQClbAgWkB9zgdfey1g2sE= X-Gm-Gg: ASbGncupJahgMj9F6Ii/qchwNs67veWjjhEvgL18abO6U9tUYMOpNlvovQT9hsldjNI ijEWd9wfGGXz0WJuDg0LjNaFB3JpId59C7XVZ70zDgSqFTmqI9oiQD67ghc/mPuoM1MgsJHRGYC TaH92KC7Ws1JDL6lbq/Hj4wujEKqzhmnrnUmW+BweXHdSkuj3oKFExNNUq7SIkzJ6pB0MQ8D2GQ zR44UDnapfsp96yjvBaTE2YmwY4kbPuLUHGJ6XqyIBY0+GMrNKYj0dv5xtTAlf00FasPgaP2yxz WLpMAEp3Rj825frKE98VDiGIEVarI1Bj8UsXF4m1rcQnxH6GpGc4NFgiLYMcIvFNkl9MINT6JJp AQFhDbuzMGyHWl//6BdM= X-Google-Smtp-Source: AGHT+IHlesOh77cakTH2YhHv43j8zOza0rZEzGZ+37qo1i6wlvyL7TrOfPOjUkpSesJgnyG08PjCmA== X-Received: by 2002:a17:90b:1256:b0:311:abba:53b6 with SMTP id 98e67ed59e1d1-313dc25631cmr1682026a91.14.1749797897914; Thu, 12 Jun 2025 23:58:17 -0700 (PDT) Received: from localhost.localdomain ([103.97.166.196]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-313c1b49b7fsm2653022a91.24.2025.06.12.23.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 23:58:17 -0700 (PDT) From: Anup Patel To: Atish Patra Cc: Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Andrew Jones , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel Subject: [PATCH v2 05/12] RISC-V: KVM: Don't flush TLB when PTE is unchanged Date: Fri, 13 Jun 2025 12:27:36 +0530 Message-ID: <20250613065743.737102-6-apatel@ventanamicro.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613065743.737102-1-apatel@ventanamicro.com> References: <20250613065743.737102-1-apatel@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250612_235819_046128_BEA68056 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org The gstage_set_pte() and gstage_op_pte() should flush TLB only when a leaf PTE changes so that unnecessary TLB flushes can be avoided. Signed-off-by: Anup Patel --- arch/riscv/kvm/mmu.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c index 1087ea74567b..29f1bd853a66 100644 --- a/arch/riscv/kvm/mmu.c +++ b/arch/riscv/kvm/mmu.c @@ -167,9 +167,11 @@ static int gstage_set_pte(struct kvm *kvm, u32 level, ptep = &next_ptep[gstage_pte_index(addr, current_level)]; } - set_pte(ptep, *new_pte); - if (gstage_pte_leaf(ptep)) - gstage_remote_tlb_flush(kvm, current_level, addr); + if (pte_val(*ptep) != pte_val(*new_pte)) { + set_pte(ptep, *new_pte); + if (gstage_pte_leaf(ptep)) + gstage_remote_tlb_flush(kvm, current_level, addr); + } return 0; } @@ -229,7 +231,7 @@ static void gstage_op_pte(struct kvm *kvm, gpa_t addr, pte_t *ptep, u32 ptep_level, enum gstage_op op) { int i, ret; - pte_t *next_ptep; + pte_t old_pte, *next_ptep; u32 next_ptep_level; unsigned long next_page_size, page_size; @@ -258,11 +260,13 @@ static void gstage_op_pte(struct kvm *kvm, gpa_t addr, if (op == GSTAGE_OP_CLEAR) put_page(virt_to_page(next_ptep)); } else { + old_pte = *ptep; if (op == GSTAGE_OP_CLEAR) set_pte(ptep, __pte(0)); else if (op == GSTAGE_OP_WP) set_pte(ptep, __pte(pte_val(ptep_get(ptep)) & ~_PAGE_WRITE)); - gstage_remote_tlb_flush(kvm, ptep_level, addr); + if (pte_val(*ptep) != pte_val(old_pte)) + gstage_remote_tlb_flush(kvm, ptep_level, addr); } } -- 2.43.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv