From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@gmail.com>,
<netdev@vger.kernel.org>, Simon Horman <horms@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>, <mlxsw@nvidia.com>,
Antonio Quartulli <antonio@openvpn.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
<osmocom-net-gprs@lists.osmocom.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Taehee Yoo <ap420073@gmail.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
<wireguard@lists.zx2c4.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
<linux-sctp@vger.kernel.org>, Jon Maloy <jmaloy@redhat.com>,
<tipc-discussion@lists.sourceforge.net>
Subject: Re: [PATCH net-next v2 01/14] net: ipv4: Add a flags argument to iptunnel_xmit(), udp_tunnel_xmit_skb()
Date: Fri, 13 Jun 2025 09:48:58 -0700 [thread overview]
Message-ID: <20250613094858.5dfa435e@kernel.org> (raw)
In-Reply-To: <93258d0156bab6c2d8c7c6e1a43d23e13e9830ec.1749757582.git.petrm@nvidia.com>
On Thu, 12 Jun 2025 22:10:35 +0200 Petr Machata wrote:
> void udp_tunnel_xmit_skb(struct rtable *rt, struct sock *sk, struct sk_buff *skb,
> __be32 src, __be32 dst, __u8 tos, __u8 ttl,
> __be16 df, __be16 src_port, __be16 dst_port,
> - bool xnet, bool nocheck)
> + bool xnet, bool nocheck, u16 ipcb_flags)
This is a lot of arguments for a function.
I don't have a great suggestion off the top of my head, but maybe
think more about it?
next prev parent reply other threads:[~2025-06-13 16:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 20:10 [PATCH net-next v2 00/14] ipmr, ip6mr: Allow MC-routing locally-generated MC packets Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 01/14] net: ipv4: Add a flags argument to iptunnel_xmit(), udp_tunnel_xmit_skb() Petr Machata
2025-06-13 16:48 ` Jakub Kicinski [this message]
2025-06-13 19:23 ` Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 02/14] net: ipv4: ipmr: ipmr_queue_xmit(): Drop local variable `dev' Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 03/14] net: ipv4: ipmr: Split ipmr_queue_xmit() in two Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 04/14] net: ipv4: Add ip_mr_output() Petr Machata
2025-06-13 16:51 ` Jakub Kicinski
2025-06-13 19:31 ` Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 05/14] net: ipv6: Make udp_tunnel6_xmit_skb() void Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 06/14] net: ipv6: Add a flags argument to ip6tunnel_xmit(), udp_tunnel6_xmit_skb() Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 07/14] net: ipv6: ip6mr: Fix in/out netdev to pass to the FORWARD chain Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 08/14] net: ipv6: ip6mr: Extract a helper out of ip6mr_forward2() Petr Machata
2025-06-13 16:53 ` Jakub Kicinski
2025-06-13 19:40 ` Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 09/14] net: ipv6: Add ip6_mr_output() Petr Machata
2025-06-13 16:48 ` Jakub Kicinski
2025-06-13 18:59 ` Petr Machata
2025-06-13 21:52 ` Jakub Kicinski
2025-06-12 20:10 ` [PATCH net-next v2 10/14] vxlan: Support MC routing in the underlay Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 11/14] selftests: forwarding: lib: Move smcrouted helpers here Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 12/14] selftests: net: lib: Add ip_link_has_flag() Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 13/14] selftests: forwarding: adf_mcd_start(): Allow configuring custom interfaces Petr Machata
2025-06-12 20:10 ` [PATCH net-next v2 14/14] selftests: forwarding: Add a test for verifying VXLAN MC underlay Petr Machata
2025-06-13 16:57 ` Jakub Kicinski
2025-06-13 17:28 ` Matthieu Baerts
2025-06-16 15:06 ` Petr Machata
2025-06-16 16:18 ` Matthieu Baerts
2025-06-16 17:52 ` Jakub Kicinski
2025-06-16 19:53 ` Petr Machata
2025-06-16 20:40 ` Matthieu Baerts
2025-06-16 20:55 ` Jakub Kicinski
2025-06-13 15:48 ` [PATCH net-next v2 00/14] ipmr, ip6mr: Allow MC-routing locally-generated MC packets Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613094858.5dfa435e@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jmaloy@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.