Re: [PATCH v6 6/8] fs/resctrl: Introduce interface to display io_alloc CBMs

[kernel test robot <lkp@intel.com>]

Hi Babu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on brauner-vfs/vfs.all]
[also build test WARNING on linus/master v6.16-rc1 next-20250612]
[cannot apply to tip/x86/core aegl/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Babu-Moger/x86-cpufeatures-Add-support-for-L3-Smart-Data-Cache-Injection-Allocation-Enforcement/20250612-053050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/16cebf7069e11e07c0d9e343aa72363325befafd.1749677012.git.babu.moger%40amd.com
patch subject: [PATCH v6 6/8] fs/resctrl: Introduce interface to display io_alloc CBMs
config: x86_64-randconfig-r071-20250612 (https://download.01.org/0day-ci/archive/20250613/202506131254.KDDf1FdT-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506131254.KDDf1FdT-lkp@intel.com/

New smatch warnings:
fs/resctrl/rdtgroup.c:2026 resctrl_io_alloc_cbm_show() warn: unsigned 'io_alloc_closid' is never less than zero.
fs/resctrl/rdtgroup.c:2026 resctrl_io_alloc_cbm_show() warn: error code type promoted to positive: 'io_alloc_closid'

Old smatch warnings:
fs/resctrl/rdtgroup.c:1961 resctrl_io_alloc_write() warn: unsigned 'io_alloc_closid' is never less than zero.
fs/resctrl/rdtgroup.c:1961 resctrl_io_alloc_write() warn: error code type promoted to positive: 'io_alloc_closid'

vim +/io_alloc_closid +2026 fs/resctrl/rdtgroup.c

  1999	
  2000	static int resctrl_io_alloc_cbm_show(struct kernfs_open_file *of,
  2001					     struct seq_file *seq, void *v)
  2002	{
  2003		struct resctrl_schema *s = rdt_kn_parent_priv(of->kn);
  2004		struct rdt_resource *r = s->res;
  2005		u32 io_alloc_closid;
  2006		int ret = 0;
  2007	
  2008		cpus_read_lock();
  2009		mutex_lock(&rdtgroup_mutex);
  2010	
  2011		rdt_last_cmd_clear();
  2012	
  2013		if (!r->cache.io_alloc_capable) {
  2014			rdt_last_cmd_puts("io_alloc feature is not supported on the resource\n");
  2015			ret = -ENODEV;
  2016			goto cbm_show_out;
  2017		}
  2018	
  2019		if (!resctrl_arch_get_io_alloc_enabled(r)) {
  2020			rdt_last_cmd_puts("io_alloc feature is not enabled\n");
  2021			ret = -EINVAL;
  2022			goto cbm_show_out;
  2023		}
  2024	
  2025		io_alloc_closid = resctrl_io_alloc_closid_get(r);
> 2026		if (io_alloc_closid < 0) {
  2027			rdt_last_cmd_puts("Max CLOSID to support io_alloc is not available\n");
  2028			ret = -EINVAL;
  2029			goto cbm_show_out;
  2030		}
  2031	
  2032		show_doms(seq, resctrl_schema_io_alloc(s), NULL, io_alloc_closid);
  2033	
  2034	cbm_show_out:
  2035		mutex_unlock(&rdtgroup_mutex);
  2036		cpus_read_unlock();
  2037		return ret;
  2038	}
  2039	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki