Re: [PATCH, RFC] block: always use a list_head for requests

[kernel test robot <lkp@intel.com>]

Hi Christoph,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.16-rc1]
[cannot apply to axboe-block/for-next linux-nvme/for-next next-20250612]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christoph-Hellwig/block-always-use-a-list_head-for-requests/20250612-154415
base:   linus/master
patch link:    https://lore.kernel.org/r/20250612074245.2718371-1-hch%40lst.de
patch subject: [PATCH, RFC] block: always use a list_head for requests
config: i386-buildonly-randconfig-002-20250613 (https://download.01.org/0day-ci/archive/20250613/202506131506.hpiMurtj-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250613/202506131506.hpiMurtj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506131506.hpiMurtj-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/block/ublk_drv.c: In function 'ublk_queue_rqs':
>> drivers/block/ublk_drv.c:1433:37: error: passing argument 1 of 'ublk_queue_cmd_list' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1433 |                 ublk_queue_cmd_list(io, rqlist);
         |                                     ^~
         |                                     |
         |                                     struct ublk_io *
   drivers/block/ublk_drv.c:1334:49: note: expected 'struct request *' but argument is of type 'struct ublk_io *'
    1334 | static void ublk_queue_cmd_list(struct request *req, struct ublk_io *io,
         |                                 ~~~~~~~~~~~~~~~~^~~
   drivers/block/ublk_drv.c:1433:41: error: passing argument 2 of 'ublk_queue_cmd_list' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1433 |                 ublk_queue_cmd_list(io, rqlist);
         |                                         ^~~~~~
         |                                         |
         |                                         struct list_head *
   drivers/block/ublk_drv.c:1334:70: note: expected 'struct ublk_io *' but argument is of type 'struct list_head *'
    1334 | static void ublk_queue_cmd_list(struct request *req, struct ublk_io *io,
         |                                                      ~~~~~~~~~~~~~~~~^~
>> drivers/block/ublk_drv.c:1433:17: error: too few arguments to function 'ublk_queue_cmd_list'
    1433 |                 ublk_queue_cmd_list(io, rqlist);
         |                 ^~~~~~~~~~~~~~~~~~~
   drivers/block/ublk_drv.c:1334:13: note: declared here
    1334 | static void ublk_queue_cmd_list(struct request *req, struct ublk_io *io,
         |             ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/ublk_queue_cmd_list +1433 drivers/block/ublk_drv.c

  1413	
  1414	static void ublk_queue_rqs(struct list_head *rqlist)
  1415	{
  1416		struct ublk_io *io = NULL;
  1417		struct request *req, *n;
  1418		LIST_HEAD(requeue_list);
  1419	
  1420		list_for_each_entry_safe(req, n, rqlist, queuelist) {
  1421			struct ublk_queue *this_q = req->mq_hctx->driver_data;
  1422			struct ublk_io *this_io = &this_q->ios[req->tag];
  1423	
  1424			if (io && io->task != this_io->task)
  1425				ublk_queue_cmd_list(req, io, rqlist);
  1426			io = this_io;
  1427	
  1428			if (ublk_prep_req(this_q, req, true) != BLK_STS_OK)
  1429				list_move_tail(&req->queuelist, &requeue_list);
  1430		}
  1431	
  1432		if (!list_empty(rqlist))
> 1433			ublk_queue_cmd_list(io, rqlist);
  1434		list_splice(&requeue_list, rqlist);
  1435	}
  1436	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki