From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2FF0C71148 for ; Fri, 13 Jun 2025 15:55:05 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4bJkVw4BH4z2yfx; Sat, 14 Jun 2025 01:55:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:45d1:ec00::3" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1749830104; cv=none; b=HJM+i09vj1VMgN+qa3tMJBFu+JMxPSEK01Zg2P9Q1FA8230fb4cQ0mD+2gSQg3V+NWBr/O+/9BlGPBUJY/ZOsW3oQJxjU8bGyX5oYaIhcCLfSu9i6iW2ca7OtIJXXO09nX4w3wxoWIL+7fPjjmQUUrySZww/BWn5CBEVJmmGvpSpvV+Siq7+it2ovMcg8hOzwWQf9V6yyRR39Syx0Awa6TDdfxbpBO+V7aWBmVSU4QDKnkScis15LaGqktdpnovS13OJULedEBtEDxYx3ZNGetd7gU59GyeaYzcfyGFxQ8qQNz+My62eKtBZqUlSfKgbifamNlzdf8n4WJUiJCD+KQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1749830104; c=relaxed/relaxed; bh=dVpvvucvYqfu63JD/OuOOltdFqYGu1+iCXebSLkmw0E=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=KNifS+k3rQi9rZvHVv7ThJb5N1QYPbTms7XlS5qN15jff4Lozk2w/2Mt5BudrGCxDS/nSYHMQi9cLiBaJtKNx2eeiBDIyWo9mUPeQ+cEaSsC3JhpV4XU+dPtTGanPBefp3PGa3N5Yl/AkmE+Rx9Q/aP5lVEQa1vhxzbGUmBCpIWpJqQKVsoQXUGgTHSVECsHqN5sOsbxl//JxoEVz44/8t7iJZAUfNzDeshu59d5kdoFjjSt+NLwT0syi1unPvHvkD9Ypixn7Yvt4Lug6hlKCUIGbbqhrPxwmPhQsYDwN9QG4lItCz2+6sVkw9dwlNelMCELuIk/CXM5pNcCAKqP/Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=gFPoa516; dkim-atps=neutral; spf=pass (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=gFPoa516; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4bJkVv135nz2xBb; Sat, 14 Jun 2025 01:55:02 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 45683A5148E; Fri, 13 Jun 2025 15:55:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B42EBC4CEED; Fri, 13 Jun 2025 15:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749830099; bh=txoIyDrG2vubdoOdTiTdmcJQb8y7qy5caM50Zd8G8to=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=gFPoa516Ela1DPXpH0f6/CS5GkNUbZK3nAYpFk07eqEgd3MKAhYJpF0s0lR7On5mh mTRs3hEkjNSmkoYXNNxat0V6bY1VSuL9RUaPNvJuo+3M4NxXHk18J9uIsBuF7BfZSP LT2mpCyuW/nNNqy98L7h2qv/SXJaaEYTKmk9KlAx8hO5gtnc+f8HFC2H9FWk4DGBfW 6JdxNAw5ZVa4sVUYSYyFngUyMNeio0PIqep0t3E5XJuUwayNZIlc1Um9AsPD8fsgtD LX9RVvGngHT5S7OMOIWzgnwkmg0oDRjT3tctQgL7cXq2tYr8yGsydjYdO2oCDGOE4x 7e6vKtWFkarMA== Date: Fri, 13 Jun 2025 10:54:58 -0500 From: Bjorn Helgaas To: Jacky Chou Cc: bhelgaas@google.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, vkoul@kernel.org, kishon@kernel.org, linus.walleij@linaro.org, p.zabel@pengutronix.de, linux-aspeed@lists.ozlabs.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, elbadrym@google.com, romlem@google.com, anhphan@google.com, wak@google.com, yuxiaozhang@google.com, BMC-SW@aspeedtech.com Subject: Re: [PATCH 5/7] ARM: dts: aspeed-g6: Add PCIe RC node Message-ID: <20250613155458.GA962010@bhelgaas> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250613033001.3153637-6-jacky_chou@aspeedtech.com> On Fri, Jun 13, 2025 at 11:29:59AM +0800, Jacky Chou wrote: > The AST2600 has one PCIe RC, and add the relative configure regmap. > + pcie0: pcie@1e7700c0 { > + compatible = "aspeed,ast2600-pcie"; > + device_type = "pci"; > + reg = <0x1e7700c0 0x40>; > + linux,pci-domain = <0>; > + #address-cells = <3>; > + #size-cells = <2>; > + interrupts = ; > + bus-range = <0x80 0xff>; > + > + ranges = <0x01000000 0x0 0x00018000 0x00018000 0x0 0x00008000 > + 0x02000000 0x0 0x70000000 0x70000000 0x0 0x10000000>; > + > + status = "disabled"; > + > + resets = <&syscon ASPEED_RESET_H2X>, > + <&syscon ASPEED_RESET_PCIE_RC_O>; > + reset-names = "h2x", "perst"; PERST# is clearly a per-Root Port item since it's a signal on the PCIe connector. Can you separate this and any other per-Root Port things into a Root Port stanza to leave open the possibility of future hardware that supports multiple Root Ports in the RC? > + clocks = <&syscon ASPEED_CLK_GATE_BCLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcierc1_default>; > + > + #interrupt-cells = <1>; > + msi-parent = <&pcie0>; > + msi-controller; > + msi_address = <0x1e77005c>; > + > + aspeed,ahbc = <&ahbc>; > + aspeed,pciecfg = <&pcie_cfg>; > + aspeed,pciephy = <&pcie_phy1>; > + > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0 0 0 1 &pcie_intc0 0>, > + <0 0 0 2 &pcie_intc0 1>, > + <0 0 0 3 &pcie_intc0 2>, > + <0 0 0 4 &pcie_intc0 3>; > + pcie_intc0: interrupt-controller { > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <1>; > + }; > + }; > + > gfx: display@1e6e6000 { > compatible = "aspeed,ast2600-gfx", "syscon"; > reg = <0x1e6e6000 0x1000>; > -- > 2.43.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CF01C71136 for ; Fri, 13 Jun 2025 18:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=GluS41rTnt/rofDdDL99KA7L219fDcaJ8nJ0OEibXXQ=; b=KKjG/KK+YlZwzp CGTnj1mlw6M49SYPXcdAwEsMs1/PJuh417Ks13dy7o+hGaK+O0NVsWH17ROSIXg2+bH8Vn2f3gbj8 9KX7qBIQNAkLlwRLSVPumkgbatghCpJwANvGhRtgQ6E9uBynSGwA9v61kEF/rubkbIxivOZrME8NU VnyHvAcnyWnxiESue7OnpbYp7HI/MHcZbiJS3IAmm7tMlQNkTP3i7TDtu7PWAUeJveDAK5WNysfgq KRRZiqzVsn3YzaYgYuLKPb7PYjXgw2Dna26OJKkUHOERLEMPMknWLEbJgUpITScROMQ/b2q2F+RG3 9+zLGZWh+vp0iIjKJc0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ8xd-0000000HGOx-3R56; Fri, 13 Jun 2025 18:17:05 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ6kC-0000000GyDu-3jJb; Fri, 13 Jun 2025 15:55:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=dVpvvucvYqfu63JD/OuOOltdFqYGu1+iCXebSLkmw0E=; b=nEK79bFPrE4kBlNsSUJFomGUop 0hKZBPjRAIgx/xXGXXJWb3PncadBm8irZoYz/gWWa4FQwJ9srNcqrLkuei72LGulbps+XtTITxgs5 Iv4BrzF+bQx8N3jq4NEsly5nYCQg5V+EUoJqGExMjMeCbgRCFGvXkN0J0dW6Wl2un/y+angG+36Jw h6Y6wKGlcGi4EskWmW6JLfQtNTJIdn5JPrLF5QC7jVS8RmXiiXL+wGuZkiEKaqMqNjiDQ+pyNJWQh iC2nZICJRt12wkKPtBltc+VA1bpvn32MTtDTgGs70PvmwtlEUWnDQNvxksADh4uHLiZjVgfseBSAI SSCUnEOg==; Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQ6kA-000000032BF-3eEY; Fri, 13 Jun 2025 15:55:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 45683A5148E; Fri, 13 Jun 2025 15:55:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B42EBC4CEED; Fri, 13 Jun 2025 15:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749830099; bh=txoIyDrG2vubdoOdTiTdmcJQb8y7qy5caM50Zd8G8to=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=gFPoa516Ela1DPXpH0f6/CS5GkNUbZK3nAYpFk07eqEgd3MKAhYJpF0s0lR7On5mh mTRs3hEkjNSmkoYXNNxat0V6bY1VSuL9RUaPNvJuo+3M4NxXHk18J9uIsBuF7BfZSP LT2mpCyuW/nNNqy98L7h2qv/SXJaaEYTKmk9KlAx8hO5gtnc+f8HFC2H9FWk4DGBfW 6JdxNAw5ZVa4sVUYSYyFngUyMNeio0PIqep0t3E5XJuUwayNZIlc1Um9AsPD8fsgtD LX9RVvGngHT5S7OMOIWzgnwkmg0oDRjT3tctQgL7cXq2tYr8yGsydjYdO2oCDGOE4x 7e6vKtWFkarMA== Date: Fri, 13 Jun 2025 10:54:58 -0500 From: Bjorn Helgaas To: Jacky Chou Cc: bhelgaas@google.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, vkoul@kernel.org, kishon@kernel.org, linus.walleij@linaro.org, p.zabel@pengutronix.de, linux-aspeed@lists.ozlabs.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, elbadrym@google.com, romlem@google.com, anhphan@google.com, wak@google.com, yuxiaozhang@google.com, BMC-SW@aspeedtech.com Subject: Re: [PATCH 5/7] ARM: dts: aspeed-g6: Add PCIe RC node Message-ID: <20250613155458.GA962010@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250613033001.3153637-6-jacky_chou@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250613_165503_131135_93E25D67 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Jun 13, 2025 at 11:29:59AM +0800, Jacky Chou wrote: > The AST2600 has one PCIe RC, and add the relative configure regmap. > + pcie0: pcie@1e7700c0 { > + compatible = "aspeed,ast2600-pcie"; > + device_type = "pci"; > + reg = <0x1e7700c0 0x40>; > + linux,pci-domain = <0>; > + #address-cells = <3>; > + #size-cells = <2>; > + interrupts = ; > + bus-range = <0x80 0xff>; > + > + ranges = <0x01000000 0x0 0x00018000 0x00018000 0x0 0x00008000 > + 0x02000000 0x0 0x70000000 0x70000000 0x0 0x10000000>; > + > + status = "disabled"; > + > + resets = <&syscon ASPEED_RESET_H2X>, > + <&syscon ASPEED_RESET_PCIE_RC_O>; > + reset-names = "h2x", "perst"; PERST# is clearly a per-Root Port item since it's a signal on the PCIe connector. Can you separate this and any other per-Root Port things into a Root Port stanza to leave open the possibility of future hardware that supports multiple Root Ports in the RC? > + clocks = <&syscon ASPEED_CLK_GATE_BCLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcierc1_default>; > + > + #interrupt-cells = <1>; > + msi-parent = <&pcie0>; > + msi-controller; > + msi_address = <0x1e77005c>; > + > + aspeed,ahbc = <&ahbc>; > + aspeed,pciecfg = <&pcie_cfg>; > + aspeed,pciephy = <&pcie_phy1>; > + > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0 0 0 1 &pcie_intc0 0>, > + <0 0 0 2 &pcie_intc0 1>, > + <0 0 0 3 &pcie_intc0 2>, > + <0 0 0 4 &pcie_intc0 3>; > + pcie_intc0: interrupt-controller { > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <1>; > + }; > + }; > + > gfx: display@1e6e6000 { > compatible = "aspeed,ast2600-gfx", "syscon"; > reg = <0x1e6e6000 0x1000>; > -- > 2.43.0 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy