All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v5] char: misc: add test cases
Date: Fri, 13 Jun 2025 20:11:48 +0800	[thread overview]
Message-ID: <202506132058.thWZHlrb-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250612-misc-dynrange-v5-1-6f35048f7273@igalia.com>
References: <20250612-misc-dynrange-v5-1-6f35048f7273@igalia.com>
TO: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>

Hi Thadeu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 19272b37aa4f83ca52bdf9c16d5d81bdd1354494]

url:    https://github.com/intel-lab-lkp/linux/commits/Thadeu-Lima-de-Souza-Cascardo/char-misc-add-test-cases/20250613-013440
base:   19272b37aa4f83ca52bdf9c16d5d81bdd1354494
patch link:    https://lore.kernel.org/r/20250612-misc-dynrange-v5-1-6f35048f7273%40igalia.com
patch subject: [PATCH v5] char: misc: add test cases
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago
config: powerpc-randconfig-r072-20250613 (https://download.01.org/0day-ci/archive/20250613/202506132058.thWZHlrb-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202506132058.thWZHlrb-lkp@intel.com/

smatch warnings:
drivers/misc/misc_minor_kunit.c:192 miscdev_test_can_open() warn: passing zero to 'PTR_ERR'

vim +/PTR_ERR +192 drivers/misc/misc_minor_kunit.c

127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  177  
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  178  static void __init miscdev_test_can_open(struct kunit *test, struct miscdevice *misc)
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  179  {
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  180  	int ret;
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  181  	struct file *filp;
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  182  	char *devname;
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  183  
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  184  	devname = kasprintf(GFP_KERNEL, "/dev/%s", misc->name);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  185  	ret = init_mknod(devname, S_IFCHR | 0600,
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  186  			 new_encode_dev(MKDEV(MISC_MAJOR, misc->minor)));
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  187  	if (ret != 0)
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  188  		KUNIT_FAIL(test, "failed to create node\n");
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  189  
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  190  	filp = filp_open(devname, O_RDONLY, 0);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  191  	if (IS_ERR_OR_NULL(filp))
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12 @192  		KUNIT_FAIL(test, "failed to open misc device: %ld\n", PTR_ERR(filp));
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  193  	else
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  194  		fput(filp);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  195  
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  196  	init_unlink(devname);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  197  	kfree(devname);
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  198  }
127b049d35f107 Thadeu Lima de Souza Cascardo 2025-06-12  199  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2025-06-13 12:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 12:11 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-12 17:32 [PATCH v5] char: misc: add test cases Thadeu Lima de Souza Cascardo
2025-06-18 17:31 ` Dan Carpenter
2025-07-09 13:14 ` kernel test robot
2025-07-09 13:23   ` Thadeu Lima de Souza Cascardo
2025-07-11  6:46     ` Oliver Sang
2025-07-30  7:08 ` Geert Uytterhoeven
2025-07-30 11:05   ` Thadeu Lima de Souza Cascardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202506132058.thWZHlrb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.