Re: [RFC PATCH v3 1/5] PCI: rockchip-host: Use standard PCIe defines

[kernel test robot <lkp@intel.com>]

Hi Geraldo,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on rockchip/for-next]
[also build test ERROR on pci/next pci/for-linus mani-mhi/mhi-next linus/master v6.16-rc1 next-20250613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Geraldo-Nascimento/PCI-rockchip-host-Use-standard-PCIe-defines/20250613-132302
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
patch link:    https://lore.kernel.org/r/fc88993a561fcc9a9960c038bbc8b0b717924888.1749791474.git.geraldogabriel%40gmail.com
patch subject: [RFC PATCH v3 1/5] PCI: rockchip-host: Use standard PCIe defines
config: s390-randconfig-002-20250614 (https://download.01.org/0day-ci/archive/20250614/202506141053.s2TxMChc-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250614/202506141053.s2TxMChc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506141053.s2TxMChc-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/pci/controller/pcie-rockchip-host.c: In function 'rockchip_pcie_enable_bw_int':
   drivers/pci/controller/pcie-rockchip-host.c:43:40: error: 'PCIE_RC_CONFIG_CR' undeclared (first use in this function); did you mean 'PCIE_RC_CONFIG_DCR'?
      43 |  status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL);
         |                                        ^~~~~~~~~~~~~~~~~
         |                                        PCIE_RC_CONFIG_DCR
   drivers/pci/controller/pcie-rockchip-host.c:43:40: note: each undeclared identifier is reported only once for each function it appears in
   drivers/pci/controller/pcie-rockchip-host.c: In function 'rockchip_pcie_clr_bw_int':
   drivers/pci/controller/pcie-rockchip-host.c:52:40: error: 'PCIE_RC_CONFIG_CR' undeclared (first use in this function); did you mean 'PCIE_RC_CONFIG_DCR'?
      52 |  status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL);
         |                                        ^~~~~~~~~~~~~~~~~
         |                                        PCIE_RC_CONFIG_DCR
   drivers/pci/controller/pcie-rockchip-host.c: In function 'rockchip_pcie_set_power_limit':
>> drivers/pci/controller/pcie-rockchip-host.c:272:17: error: implicit declaration of function 'FIELD_MAX' [-Werror=implicit-function-declaration]
     272 |  while (power > FIELD_MAX(PCI_EXP_DEVCAP_PWR_VAL)) {
         |                 ^~~~~~~~~
   drivers/pci/controller/pcie-rockchip-host.c:281:40: error: 'PCIE_RC_CONFIG_CR' undeclared (first use in this function); did you mean 'PCIE_RC_CONFIG_DCR'?
     281 |  status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP);
         |                                        ^~~~~~~~~~~~~~~~~
         |                                        PCIE_RC_CONFIG_DCR
>> drivers/pci/controller/pcie-rockchip-host.c:282:12: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     282 |  status |= FIELD_PREP(PCI_EXP_DEVCAP_PWR_VAL, power);
         |            ^~~~~~~~~~
   drivers/pci/controller/pcie-rockchip-host.c: In function 'rockchip_pcie_host_init_port':
   drivers/pci/controller/pcie-rockchip-host.c:312:40: error: 'PCIE_RC_CONFIG_CR' undeclared (first use in this function); did you mean 'PCIE_RC_CONFIG_DCR'?
     312 |  status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL);
         |                                        ^~~~~~~~~~~~~~~~~
         |                                        PCIE_RC_CONFIG_DCR
   cc1: some warnings being treated as errors


vim +/FIELD_MAX +272 drivers/pci/controller/pcie-rockchip-host.c

   250	
   251	static void rockchip_pcie_set_power_limit(struct rockchip_pcie *rockchip)
   252	{
   253		int curr;
   254		u32 status, scale, power;
   255	
   256		if (IS_ERR(rockchip->vpcie3v3))
   257			return;
   258	
   259		/*
   260		 * Set RC's captured slot power limit and scale if
   261		 * vpcie3v3 available. The default values are both zero
   262		 * which means the software should set these two according
   263		 * to the actual power supply.
   264		 */
   265		curr = regulator_get_current_limit(rockchip->vpcie3v3);
   266		if (curr <= 0)
   267			return;
   268	
   269		scale = 3; /* 0.001x */
   270		curr = curr / 1000; /* convert to mA */
   271		power = (curr * 3300) / 1000; /* milliwatt */
 > 272		while (power > FIELD_MAX(PCI_EXP_DEVCAP_PWR_VAL)) {
   273			if (!scale) {
   274				dev_warn(rockchip->dev, "invalid power supply\n");
   275				return;
   276			}
   277			scale--;
   278			power = power / 10;
   279		}
   280	
   281		status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP);
 > 282		status |= FIELD_PREP(PCI_EXP_DEVCAP_PWR_VAL, power);
   283		status |= FIELD_PREP(PCI_EXP_DEVCAP_PWR_SCL, scale);
   284		rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP);
   285	}
   286	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki