From: Jakub Kicinski <kuba@kernel.org>
To: Gustavo Luiz Duarte <gustavold@gmail.com>
Cc: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/5] netconsole: append msgid to sysdata
Date: Sat, 14 Jun 2025 12:51:49 -0700 [thread overview]
Message-ID: <20250614125149.55a8bc1f@kernel.org> (raw)
In-Reply-To: <20250612-netconsole-msgid-v2-3-d4c1abc84bac@gmail.com>
On Thu, 12 Jun 2025 13:02:16 -0700 Gustavo Luiz Duarte wrote:
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> index 3bf8777fcd01..baa9862c1bc3 100644
> --- a/drivers/net/netconsole.c
> +++ b/drivers/net/netconsole.c
> @@ -155,6 +155,8 @@ struct netconsole_target {
> size_t userdata_length;
> /* bit-wise with sysdata_feature bits */
> u32 sysdata_fields;
> + /* protected by target_list_lock */
> + u32 msgcounter;
> #endif
kdoc is complaining that:
drivers/net/netconsole.c:167 struct member 'msgcounter' not described in 'netconsole_target'
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-14 19:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 20:02 [PATCH net-next v2 0/5] netconsole: Add support for msgid in sysdata Gustavo Luiz Duarte
2025-06-12 20:02 ` [PATCH net-next v2 1/5] netconsole: introduce 'msgid' as a new sysdata field Gustavo Luiz Duarte
2025-06-12 20:02 ` [PATCH net-next v2 2/5] netconsole: implement configfs for msgid_enabled Gustavo Luiz Duarte
2025-06-12 20:02 ` [PATCH net-next v2 3/5] netconsole: append msgid to sysdata Gustavo Luiz Duarte
2025-06-14 19:51 ` Jakub Kicinski [this message]
2025-06-16 16:07 ` Gustavo Luiz Duarte
2025-06-12 20:02 ` [PATCH net-next v2 4/5] selftests: netconsole: Add tests for 'msgid' feature in sysdata Gustavo Luiz Duarte
2025-06-12 20:02 ` [PATCH net-next v2 5/5] docs: netconsole: document msgid feature Gustavo Luiz Duarte
2025-06-13 2:51 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614125149.55a8bc1f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.