From: Jakub Kicinski <kuba@kernel.org>
To: Neal Cardwell <ncardwell.sw@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH net-next 1/3] tcp: remove obsolete and unused RFC3517/RFC6675 loss recovery code
Date: Sat, 14 Jun 2025 13:07:17 -0700 [thread overview]
Message-ID: <20250614130717.40a42cce@kernel.org> (raw)
In-Reply-To: <20250613230907.1702265-2-ncardwell.sw@gmail.com>
On Fri, 13 Jun 2025 19:09:04 -0400 Neal Cardwell wrote:
> RACK-TLP loss detection has been enabled as the default loss detection
> algorithm for Linux TCP since 2018, in:
>
> commit b38a51fec1c1 ("tcp: disable RFC6675 loss detection")
Hi! There is a warning here:
net/ipv4/tcp_input.c:2959:6: warning: variable 'fast_rexmit' set but not used [-Wunused-but-set-variable]
2959 | int fast_rexmit = 0, flag = *ack_flag;
| ^
and another one in patch 2:
net/ipv4/tcp_input.c:3367:29: warning: variable ‘delta’ set but not used [-Wunused-but-set-variable]
3367 | int delta;
| ^~~~~
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-14 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 23:09 [PATCH net-next 0/3] tcp: remove obsolete RFC3517/RFC6675 code Neal Cardwell
2025-06-13 23:09 ` [PATCH net-next 1/3] tcp: remove obsolete and unused RFC3517/RFC6675 loss recovery code Neal Cardwell
2025-06-14 20:07 ` Jakub Kicinski [this message]
2025-06-15 0:18 ` Neal Cardwell
2025-06-14 22:03 ` kernel test robot
2025-06-13 23:09 ` [PATCH net-next 2/3] tcp: remove RFC3517/RFC6675 hint state: lost_skb_hint, lost_cnt_hint Neal Cardwell
2025-06-14 22:55 ` kernel test robot
2025-06-13 23:09 ` [PATCH net-next 3/3] tcp: remove RFC3517/RFC6675 tcp_clear_retrans_hints_partial() Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614130717.40a42cce@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ncardwell.sw@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.