From: Jakub Kicinski <kuba@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Gal Pressman <gal@nvidia.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
"David S. Miller" <davem@davemloft.net>,
Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Ilya Maximets <i.maximets@ovn.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net] openvswitch: Allocate struct ovs_pcpu_storage dynamically
Date: Mon, 16 Jun 2025 15:09:02 -0700 [thread overview]
Message-ID: <20250616150902.330c4ac3@kernel.org> (raw)
In-Reply-To: <20250613123629.-XSoQTCu@linutronix.de>
On Fri, 13 Jun 2025 14:36:29 +0200 Sebastian Andrzej Siewior wrote:
> PERCPU_MODULE_RESERVE defines the maximum size that can by used for the
> per-CPU data size used by modules. This is 8KiB.
>
> Commit 035fcdc4d240c ("openvswitch: Merge three per-CPU structures into
> one") restructured the per-CPU memory allocation for the module and
> moved the separate alloc_percpu() invocations at module init time to a
> static per-CPU variable which is allocated by the module loader.
IIUC you're saying that the module loader only gets 8kB but dynamic
allocations from the code don't have this restriction?
Maybe just me but TBH the commit message reads like the inverse :S
> The size of the per-CPU data section for openvswitch is 6488 bytes which
> is ~80% of the available per-CPU memory. Together with a few other
> modules it is easy to exhaust the available 8KiB of memory.
>
> Allocate ovs_pcpu_storage dynamically at module init time.
Gal, should we wait for your testing or apply?
next prev parent reply other threads:[~2025-06-16 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 12:36 [PATCH net] openvswitch: Allocate struct ovs_pcpu_storage dynamically Sebastian Andrzej Siewior
2025-06-16 22:09 ` Jakub Kicinski [this message]
2025-06-17 7:58 ` Sebastian Andrzej Siewior
2025-06-17 8:00 ` Gal Pressman
2025-06-17 11:31 ` [ovs-dev] " Aaron Conole
2025-06-17 13:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616150902.330c4ac3@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.