From: Jakub Kicinski <kuba@kernel.org>
To: Tonghao Zhang <tonghao@bamaicloud.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Zengbing Tu <tuzengbing@didiglobal.com>
Subject: Re: [net-next v6 1/4] net: bonding: add broadcast_neighbor option for 802.3ad
Date: Mon, 16 Jun 2025 16:04:31 -0700 [thread overview]
Message-ID: <20250616160431.2aff8ec6@kernel.org> (raw)
In-Reply-To: <ff319dfdedc2bc319431c49d7f71faaa80c42d44.1749525581.git.tonghao@bamaicloud.com>
On Tue, 10 Jun 2025 11:44:42 +0800 Tonghao Zhang wrote:
> + if (bond->params.broadcast_neighbor)
> + static_branch_inc(&bond_bcast_neigh_enabled);
> }
>
> if (bond_mode_can_use_xmit_hash(bond))
> @@ -4475,6 +4480,10 @@ static int bond_close(struct net_device *bond_dev)
> bond_alb_deinitialize(bond);
> bond->recv_probe = NULL;
>
> + if (BOND_MODE(bond) == BOND_MODE_8023AD &&
> + bond->params.broadcast_neighbor)
> + static_branch_dec(&bond_bcast_neigh_enabled);
is .broadcast_neighbor automatically cleared when mode is changed?
I don't see it in the code.
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-16 23:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 3:44 [net-next v6 0/4] add broadcast_neighbor for no-stacking networking arch Tonghao Zhang
2025-06-10 3:44 ` [net-next v6 1/4] net: bonding: add broadcast_neighbor option for 802.3ad Tonghao Zhang
2025-06-16 23:04 ` Jakub Kicinski [this message]
2025-06-17 10:25 ` Tonghao Zhang
2025-06-10 3:44 ` [net-next v6 2/4] net: bonding: add broadcast_neighbor netlink option Tonghao Zhang
2025-06-10 3:44 ` [net-next v6 3/4] net: bonding: send peer notify when failure recovery Tonghao Zhang
2025-06-17 0:36 ` Jay Vosburgh
2025-06-17 10:47 ` Tonghao Zhang
2025-06-17 11:39 ` Tonghao Zhang
2025-06-18 2:51 ` Tonghao Zhang
2025-06-10 3:44 ` [net-next v6 4/4] net: bonding: add tracepoint for 802.3ad Tonghao Zhang
2025-06-17 0:28 ` Jay Vosburgh
2025-06-17 10:37 ` Tonghao Zhang
2025-06-23 2:11 ` Tonghao Zhang
2025-06-24 19:43 ` Jay Vosburgh
2025-06-26 2:57 ` Tonghao Zhang
2025-06-16 2:07 ` [net-next v6 0/4] add broadcast_neighbor for no-stacking networking arch Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616160431.2aff8ec6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=rostedt@goodmis.org \
--cc=tonghao@bamaicloud.com \
--cc=tuzengbing@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.