From: Simon Horman <horms@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Mark Zhang <markzhang@nvidia.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>,
Patrisious Haddad <phaddad@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH net] net/mlx4e: Remove redundant definition of IB_MTU_XXX
Date: Mon, 16 Jun 2025 17:36:02 +0100 [thread overview]
Message-ID: <20250616163602.GA4794@horms.kernel.org> (raw)
In-Reply-To: <aca9b2c482b4bea91e3750b15b2b00a33ee0265a.1750062150.git.leon@kernel.org>
On Mon, Jun 16, 2025 at 11:24:23AM +0300, Leon Romanovsky wrote:
> From: Mark Zhang <markzhang@nvidia.com>
>
> Remove them to avoid "redeclaration of enumerator" build error, as they
> are already defined in ib_verbs.h. This is needed for the following
> patch, which need to include the ib_verbs.h.
>
> Fixes: 096335b3f983 ("mlx4_core: Allow dynamic MTU configuration for IB ports")
> Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
> Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Hi Mark, Leon, all,
If I understand things correctly, without this patch the driver
compiles and functions correctly. But if it is modified to
include rdma/ib_verbs.h, which is required for some other forthcoming
change, then the other parts of this patch are needed to avoid a build
failure.
If so, this doesn't match my understanding of a bug fix.
Rather, it seems like a change (for net-next; no fixess tag?) which could
be included in the patch-set that needs rdma/ib_verbs.h included
in this file.
next prev parent reply other threads:[~2025-06-16 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 8:24 [PATCH net] net/mlx4e: Remove redundant definition of IB_MTU_XXX Leon Romanovsky
2025-06-16 16:36 ` Simon Horman [this message]
2025-06-16 18:33 ` Leon Romanovsky
2025-06-16 20:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616163602.GA4794@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.