All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-xfs@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Carlos  Maiolino <cem@kernel.org>, Christoph Hellwig <hch@lst.de>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: [PATCH v2 10/13] xfs: remove unused event xfs_pagecache_inval
Date: Mon, 16 Jun 2025 13:51:56 -0400	[thread overview]
Message-ID: <20250616175258.192340775@goodmis.org> (raw)
In-Reply-To: 20250616175146.813055227@goodmis.org

From: Steven Rostedt <rostedt@goodmis.org>

When the function xfs_flushinval_pages() was removed, it removed the only
caller to the trace event xfs_pagecache_inval. As trace events can take up
to 5K of memory in text and meta data each regardless if they are used or
not, they should not be created when unused. Remove the unused event.

Fixes: fb59581404ab ("xfs: remove xfs_flushinval_pages")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/xfs/xfs_trace.h | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index e629ee44a9a1..098ef23598fe 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -1893,31 +1893,6 @@ DEFINE_EVENT(xfs_itrunc_class, name, \
 DEFINE_ITRUNC_EVENT(xfs_itruncate_extents_start);
 DEFINE_ITRUNC_EVENT(xfs_itruncate_extents_end);
 
-TRACE_EVENT(xfs_pagecache_inval,
-	TP_PROTO(struct xfs_inode *ip, xfs_off_t start, xfs_off_t finish),
-	TP_ARGS(ip, start, finish),
-	TP_STRUCT__entry(
-		__field(dev_t, dev)
-		__field(xfs_ino_t, ino)
-		__field(xfs_fsize_t, size)
-		__field(xfs_off_t, start)
-		__field(xfs_off_t, finish)
-	),
-	TP_fast_assign(
-		__entry->dev = VFS_I(ip)->i_sb->s_dev;
-		__entry->ino = ip->i_ino;
-		__entry->size = ip->i_disk_size;
-		__entry->start = start;
-		__entry->finish = finish;
-	),
-	TP_printk("dev %d:%d ino 0x%llx disize 0x%llx start 0x%llx finish 0x%llx",
-		  MAJOR(__entry->dev), MINOR(__entry->dev),
-		  __entry->ino,
-		  __entry->size,
-		  __entry->start,
-		  __entry->finish)
-);
-
 TRACE_EVENT(xfs_bunmap,
 	TP_PROTO(struct xfs_inode *ip, xfs_fileoff_t fileoff, xfs_filblks_t len,
 		 int flags, unsigned long caller_ip),
-- 
2.47.2



  parent reply	other threads:[~2025-06-16 17:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 17:51 [PATCH v2 00/13] xfs: tracing: remove unused event xfs_reflink_cow_found Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 01/13] xfs: remove unused trace event xfs_attr_remove_iter_return Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 02/13] xfs: remove unused event xlog_iclog_want_sync Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 03/13] xfs: remove unused event xfs_ioctl_clone Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 04/13] xfs: remove unused xfs_reflink_compare_extents events Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 05/13] xfs: remove unused trace event xfs_attr_rmtval_set Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 06/13] xfs: remove unused xfs_attr events Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 07/13] xfs: remove unused event xfs_attr_node_removename Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 08/13] xfs: remove unused event xfs_alloc_near_error Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 09/13] xfs: remove unused event xfs_alloc_near_nominleft Steven Rostedt
2025-06-16 17:51 ` Steven Rostedt [this message]
2025-06-16 17:51 ` [PATCH v2 11/13] xfs: remove usused xfs_end_io_direct events Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 12/13] xfs: only create event xfs_file_compat_ioctl when CONFIG_COMPAT is configure Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 13/13] xfs: change xfs_xattr_class from a TRACE_EVENT() to DECLARE_EVENT_CLASS() Steven Rostedt
2025-06-16 19:18 ` [PATCH v2 00/13] xfs: tracing: remove unused event xfs_reflink_cow_found Steven Rostedt
2025-07-08 22:09 ` Steven Rostedt
2025-07-09  7:52   ` Carlos Maiolino
2025-07-09  7:54   ` Carlos Maiolino
2025-07-09 14:55     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616175258.192340775@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.