From: Eric Biggers <ebiggers@kernel.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
loongarch@lists.linux.dev, Guo Ren <guoren@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Fix build warnings about export.h
Date: Mon, 16 Jun 2025 18:57:37 +0000 [thread overview]
Message-ID: <20250616185737.GA23807@google.com> (raw)
In-Reply-To: <20250608141509.157300-1-chenhuacai@loongson.cn>
On Sun, Jun 08, 2025 at 10:15:09PM +0800, Huacai Chen wrote:
> diff --git a/arch/loongarch/lib/crc32-loongarch.c b/arch/loongarch/lib/crc32-loongarch.c
> index b37cd8537b45..db22c2ec55e2 100644
> --- a/arch/loongarch/lib/crc32-loongarch.c
> +++ b/arch/loongarch/lib/crc32-loongarch.c
> @@ -11,6 +11,7 @@
>
> #include <asm/cpu-features.h>
> #include <linux/crc32.h>
> +#include <linux/export.h>
> #include <linux/module.h>
> #include <linux/unaligned.h>
You can drop the change to crc32-loongarch.c, as it would conflict with
https://lore.kernel.org/r/20250601224441.778374-8-ebiggers@kernel.org/ and
https://lore.kernel.org/r/20250612183852.114878-1-ebiggers@kernel.org/ which are
in crc-next for 6.17 and already handle this issue.
- Eric
next prev parent reply other threads:[~2025-06-16 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 14:15 [PATCH] LoongArch: Fix build warnings about export.h Huacai Chen
2025-06-09 0:39 ` Masahiro Yamada
2025-06-16 18:57 ` Eric Biggers [this message]
2025-06-19 12:28 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616185737.GA23807@google.com \
--to=ebiggers@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=guoren@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.