From: Eric Biggers <ebiggers@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] PCI/PTM: Build debugfs code only if CONFIG_DEBUG_FS is enabled
Date: Mon, 16 Jun 2025 20:43:21 -0700 [thread overview]
Message-ID: <20250617034321.GF8289@sol> (raw)
In-Reply-To: <20250608033305.15214-1-manivannan.sadhasivam@linaro.org>
On Sun, Jun 08, 2025 at 09:03:05AM +0530, Manivannan Sadhasivam wrote:
> Otherwise, the following build error will happen for CONFIG_DEBUG_FS=n &&
> CONFIG_PCIE_PTM=y.
>
> drivers/pci/pcie/ptm.c:498:25: error: redefinition of 'pcie_ptm_create_debugfs'
> 498 | struct pci_ptm_debugfs *pcie_ptm_create_debugfs(struct device *dev, void *pdata,
> | ^
> ./include/linux/pci.h:1915:2: note: previous definition is here
> 1915 | *pcie_ptm_create_debugfs(struct device *dev, void *pdata,
> | ^
> drivers/pci/pcie/ptm.c:546:6: error: redefinition of 'pcie_ptm_destroy_debugfs'
> 546 | void pcie_ptm_destroy_debugfs(struct pci_ptm_debugfs *ptm_debugfs)
> | ^
> ./include/linux/pci.h:1918:1: note: previous definition is here
> 1918 | pcie_ptm_destroy_debugfs(struct pci_ptm_debugfs *ptm_debugfs) { }
> |
>
> Fixes: 132833405e61 ("PCI: Add debugfs support for exposing PTM context")
> Reported-by: Eric Biggers <ebiggers@kernel.org>
> Closes: https://lore.kernel.org/linux-pci/20250607025506.GA16607@sol
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/pci/pcie/ptm.c | 2 ++
> 1 file changed, 2 insertions(+)
This is still broken in mainline. Bjorn, can you apply this?
- Eric
next prev parent reply other threads:[~2025-06-17 3:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 3:33 [PATCH] PCI/PTM: Build debugfs code only if CONFIG_DEBUG_FS is enabled Manivannan Sadhasivam
2025-06-09 0:08 ` Eric Biggers
2025-06-09 3:13 ` Manivannan Sadhasivam
2025-06-09 22:33 ` Sathyanarayanan Kuppuswamy
2025-06-17 3:43 ` Eric Biggers [this message]
2025-06-23 18:07 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617034321.GF8289@sol \
--to=ebiggers@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.