From: Leon Romanovsky <leon@kernel.org>
To: Steve Wahl <steve.wahl@hpe.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org,
Vishal Chourasia <vishalc@linux.ibm.com>,
samir <samir@linux.ibm.com>,
Naman Jain <namjain@linux.microsoft.com>,
Saurabh Singh Sengar <ssengar@linux.microsoft.com>,
srivatsa@csail.mit.edu, Michael Kelley <mhklinux@outlook.com>,
Russ Anderson <rja@hpe.com>, Dimitri Sivanich <sivanich@hpe.com>
Subject: Re: [PATCH v4 1/2] sched/topology: improve topology_span_sane speed
Date: Tue, 17 Jun 2025 10:34:42 +0300 [thread overview]
Message-ID: <20250617073442.GG750234@unreal> (raw)
In-Reply-To: <aFAnwZLdGn8zrrqG@swahl-home.5wahls.com>
On Mon, Jun 16, 2025 at 09:18:41AM -0500, Steve Wahl wrote:
> On Sun, Jun 15, 2025 at 09:42:07AM +0300, Leon Romanovsky wrote:
> > On Thu, Jun 12, 2025 at 04:11:52PM +0530, K Prateek Nayak wrote:
> > > On 6/12/2025 3:00 PM, K Prateek Nayak wrote:
> > > > Ah! Since this happens so early topology isn't created yet for
> > > > the debug prints to hit! Is it possible to get a dmesg with
> > > > "ignore_loglevel" and "sched_verbose" on an older kernel that
> > > > did not throw this error on the same host?
> >
> > This is dmesg with reverted two commits "ched/topology: Refinement to
> > topology_span_sane speedup" and "sched/topology: improve
> > topology_span_sane speed"
<...>
> > >
> > > One better would be running with the following diff on top of v6.16-rc1
> > > is possible:
> >
> > We are working to get this one too.
[ 0.435961] smp: Bringing up secondary CPUs ...
[ 0.437573] smpboot: x86: Booting SMP configuration:
[ 0.438611] .... node #0, CPUs: #1
[ 0.440449] .... node #1, CPUs: #2 #3
[ 0.442906] .... node #2, CPUs: #4 #5
[ 0.445298] .... node #3, CPUs: #6 #7
[ 0.447715] .... node #4, CPUs: #8 #9
[ 0.481482] smp: Brought up 5 nodes, 10 CPUs
[ 0.483160] smpboot: Total of 10 processors activated (45892.16 BogoMIPS)
[ 0.486872] tl(SMT) CPU(0) ID(0) CPU_TL_SPAN(0) ID_TL_SPAN(0)
[ 0.488029] tl(SMT) CPU(1) ID(1) CPU_TL_SPAN(1) ID_TL_SPAN(1)
[ 0.489151] tl(SMT) CPU(2) ID(2) CPU_TL_SPAN(2) ID_TL_SPAN(2)
[ 0.489761] tl(SMT) CPU(3) ID(3) CPU_TL_SPAN(3) ID_TL_SPAN(3)
[ 0.490876] tl(SMT) CPU(4) ID(4) CPU_TL_SPAN(4) ID_TL_SPAN(4)
[ 0.491996] tl(SMT) CPU(5) ID(5) CPU_TL_SPAN(5) ID_TL_SPAN(5)
[ 0.493115] tl(SMT) CPU(6) ID(6) CPU_TL_SPAN(6) ID_TL_SPAN(6)
[ 0.493754] tl(SMT) CPU(7) ID(7) CPU_TL_SPAN(7) ID_TL_SPAN(7)
[ 0.494875] tl(SMT) CPU(8) ID(8) CPU_TL_SPAN(8) ID_TL_SPAN(8)
[ 0.496008] tl(SMT) CPU(9) ID(9) CPU_TL_SPAN(9) ID_TL_SPAN(9)
[ 0.497129] tl(PKG) CPU(0) ID(0) CPU_TL_SPAN(0-1) ID_TL_SPAN(0-1)
[ 0.497763] tl(PKG) CPU(1) ID(0) CPU_TL_SPAN(0-1) ID_TL_SPAN(0-1)
[ 0.498954] tl(PKG) CPU(2) ID(2) CPU_TL_SPAN(2-3) ID_TL_SPAN(2-3)
[ 0.500167] tl(PKG) CPU(3) ID(2) CPU_TL_SPAN(2-3) ID_TL_SPAN(2-3)
[ 0.501371] tl(PKG) CPU(4) ID(4) CPU_TL_SPAN(4-5) ID_TL_SPAN(4-5)
[ 0.501792] tl(PKG) CPU(5) ID(4) CPU_TL_SPAN(4-5) ID_TL_SPAN(4-5)
[ 0.503001] tl(PKG) CPU(6) ID(6) CPU_TL_SPAN(6-7) ID_TL_SPAN(6-7)
[ 0.504202] tl(PKG) CPU(7) ID(6) CPU_TL_SPAN(6-7) ID_TL_SPAN(6-7)
[ 0.505419] tl(PKG) CPU(8) ID(8) CPU_TL_SPAN(8-9) ID_TL_SPAN(8-9)
[ 0.506637] tl(PKG) CPU(9) ID(8) CPU_TL_SPAN(8-9) ID_TL_SPAN(8-9)
[ 0.507843] tl(NODE) CPU(0) ID(0) CPU_TL_SPAN(0-1,8-9) ID_TL_SPAN(0-1,8-9)
[ 0.509199] tl(NODE) CPU(1) ID(0) CPU_TL_SPAN(0-1,8-9) ID_TL_SPAN(0-1,8-9)
[ 0.509792] tl(NODE) CPU(2) ID(2) CPU_TL_SPAN(2-3,8-9) ID_TL_SPAN(2-3,8-9)
[ 0.511143] Failed tl: NODE
[ 0.511789] Failed for CPU: 2
[ 0.512466] ID CPU at tl: 2
[ 0.513115] Failed CPU span at tl: 2-3,8-9
[ 0.513701] ID CPU span: 2-3,8-9
[ 0.514419] ID CPUs seen: 0
[ 0.515055] CPUs covered: 0-1,8-9
[ 0.515802] ------------[ cut here ]------------
[ 0.516753] WARNING: CPU: 0 PID: 1 at kernel/sched/topology.c:2499 build_sched_domains.cold+0x96/0x23a
[ 0.517937] Modules linked in:
[ 0.518630] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.16.0-rc1master_70c6e66 #1 NONE
[ 0.520353] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014
[ 0.522008] RIP: 0010:build_sched_domains.cold+0x96/0x23a
[ 0.523102] Code: c2 80 33 91 83 48 c7 c7 0d 6e 68 82 e8 76 1f 00 00 8b 35 80 1d f8 01 48 c7 c2 c0 33 91 83 48 c7 c7 24 6e 68 82 e8 5d 1f 00 00 <0f> 0b bd f4 ff ff ff e9 fe 08 28 00 be 40 00 00 00 bf 0f 00 00 00
[ 0.526338] RSP: 0000:ffff88810096be18 EFLAGS: 00010246
[ 0.527408] RAX: 0000000000000015 RBX: 0000000000000002 RCX: ffff88843ffd26a8
[ 0.528804] RDX: 0000000000000000 RSI: 0000000000000003 RDI: 0000000000000001
[ 0.529808] RBP: ffff888100062150 R08: 0000000000000000 R09: 0000000000000000
[ 0.531211] R10: 0000000000000001 R11: 0000000000000001 R12: 0000000000000002
[ 0.532607] R13: 0000000000000002 R14: 0000000000000002 R15: ffff88838000b480
[ 0.533813] FS: 0000000000000000(0000) GS:ffff8881b9358000(0000) knlGS:0000000000000000
[ 0.535478] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.536639] CR2: ffff88843ffff000 CR3: 0000000002e5d001 CR4: 0000000000370eb0
[ 0.537802] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 0.539203] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 0.540564] Call Trace:
[ 0.541138] <TASK>
[ 0.541647] sched_init_smp+0x32/0xa0
[ 0.542434] kernel_init_freeable+0x169/0x330
[ 0.543329] ? rest_init+0x1b0/0x1b0
[ 0.544092] kernel_init+0x17/0x140
[ 0.544830] ret_from_fork+0x140/0x1b0
[ 0.545419] ? rest_init+0x1b0/0x1b0
[ 0.546185] ret_from_fork_asm+0x11/0x20
[ 0.547041] </TASK>
[ 0.547586] irq event stamp: 8887
[ 0.548321] hardirqs last enabled at (8897): [<ffffffff814b3b9a>] __up_console_sem+0x5a/0x70
[ 0.549918] hardirqs last disabled at (8908): [<ffffffff814b3b7f>] __up_console_sem+0x3f/0x70
[ 0.551593] softirqs last enabled at (8292): [<ffffffff814363b2>] irq_exit_rcu+0x82/0xe0
[ 0.553208] softirqs last disabled at (8285): [<ffffffff814363b2>] irq_exit_rcu+0x82/0xe0
[ 0.553909] ---[ end trace 0000000000000000 ]---
next prev parent reply other threads:[~2025-06-17 7:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 16:08 [PATCH v4 0/2] Improving topology_span_sane Steve Wahl
2025-03-04 16:08 ` [PATCH v4 1/2] sched/topology: improve topology_span_sane speed Steve Wahl
2025-04-08 19:05 ` [tip: sched/core] " tip-bot2 for Steve Wahl
2025-06-10 11:07 ` [PATCH v4 1/2] " Leon Romanovsky
2025-06-10 11:33 ` K Prateek Nayak
2025-06-10 12:36 ` Leon Romanovsky
2025-06-10 13:09 ` Leon Romanovsky
2025-06-10 19:39 ` Steve Wahl
2025-06-11 6:06 ` Leon Romanovsky
2025-06-11 6:56 ` K Prateek Nayak
2025-06-12 7:41 ` Leon Romanovsky
2025-06-12 9:30 ` K Prateek Nayak
2025-06-12 10:41 ` K Prateek Nayak
2025-06-15 6:42 ` Leon Romanovsky
2025-06-16 14:18 ` Steve Wahl
2025-06-17 3:04 ` K Prateek Nayak
2025-06-17 7:55 ` Leon Romanovsky
2025-06-17 7:34 ` Leon Romanovsky [this message]
2025-06-17 9:22 ` K Prateek Nayak
2025-06-23 6:06 ` K Prateek Nayak
2025-03-04 16:08 ` [PATCH v4 2/2] sched/topology: Refinement to topology_span_sane speedup Steve Wahl
2025-04-08 19:05 ` [tip: sched/core] " tip-bot2 for Steve Wahl
2025-03-06 6:46 ` [PATCH v4 0/2] Improving topology_span_sane K Prateek Nayak
2025-03-06 14:33 ` Valentin Schneider
2025-03-07 10:06 ` Madadi Vineeth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617073442.GG750234@unreal \
--to=leon@kernel.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=namjain@linux.microsoft.com \
--cc=peterz@infradead.org \
--cc=rja@hpe.com \
--cc=rostedt@goodmis.org \
--cc=samir@linux.ibm.com \
--cc=sivanich@hpe.com \
--cc=srivatsa@csail.mit.edu \
--cc=ssengar@linux.microsoft.com \
--cc=steve.wahl@hpe.com \
--cc=vincent.guittot@linaro.org \
--cc=vishalc@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.