From: Rob Herring <robh@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
sophgo@lists.linux.dev, Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
Date: Tue, 17 Jun 2025 08:09:24 -0500 [thread overview]
Message-ID: <20250617130924.GA1678432-robh@kernel.org> (raw)
In-Reply-To: <ywln42bb3i5hyzlsmfbx3xt2kjbefqmcxytcqxdcgah77gcesi@2cdw3cgxbg4c>
On Mon, Jun 09, 2025 at 06:49:38AM +0800, Inochi Amaoto wrote:
> On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> > The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> > path 'soc'. However, the correct place for RTC bindings (even if it's
> > also a "syscon") is the rtc directory, so move the binding there while
> > fixing the $id value.
> >
> > Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> > .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > similarity index 96%
> > rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > index 5cf186c396c9..c695d2ff9fcc 100644
> > --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > %YAML 1.2
> > ---
> > -$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
> > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > title: Real Time Clock of the Sophgo CV1800 SoC
> > --
> > 2.47.2
> >
>
> As the rtc syscon has a sub function for remoteproc, is it proper to
> move this binding into rtc subsystem?
Does that affect the binding (is there more to add)? Looks like an RTC
from the binding.
Rob
next prev parent reply other threads:[~2025-06-17 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 22:42 [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory Rob Herring (Arm)
2025-06-08 22:49 ` Inochi Amaoto
2025-06-17 13:09 ` Rob Herring [this message]
2025-06-17 23:18 ` Inochi Amaoto
2025-07-03 7:49 ` Krzysztof Kozlowski
2025-07-07 8:14 ` Inochi Amaoto
2025-07-03 7:49 ` Krzysztof Kozlowski
2025-07-07 21:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617130924.GA1678432-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.sverdlin@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=qiujingbao.dlmu@gmail.com \
--cc=sophgo@lists.linux.dev \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.