All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Tanish Desai <tanishdesai37@gmail.com>
Cc: qemu-devel@nongnu.org, "Lluís Vilanova" <vilanova@ac.upc.edu>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Mads Ynddal" <mads@ynddal.dk>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 0/3] tracetool:cleanup "if(true)" check from trace_foo()
Date: Tue, 17 Jun 2025 10:09:27 -0400	[thread overview]
Message-ID: <20250617140927.GB117267@fedora> (raw)
In-Reply-To: <20250616201222.6416-1-tanishdesai37@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

On Mon, Jun 16, 2025 at 08:12:19PM +0000, Tanish Desai wrote:
> This series of patch aims to removes the leftover if (true) condition from trace_foo, a remnant from the TCG tracing feature removal.
> It replaces it with a proper trace_event_get_state(...) check where necessary(for log/simple/syslog and ftrace backend).
> Additionally, this change centralizes the generation of trace_event_get_state(...) calls into format/h.py,
> eliminating redundant code across individual backends.
> This cleanup results in more consistent and less repetitive backend code.

CCing Alex Bennée, who authored commit 126d4123c50a ("tracing: excise
the tcg related from tracetool").

> 
> Tanish Desai (3):
>   tracetool: removed the unused vcpu property
>   tracetool: introduce generate_unconditional
>   tracetool: remove redundant event_get_state checks
> 
>  scripts/tracetool/backend/__init__.py |  3 +++
>  scripts/tracetool/backend/dtrace.py   |  3 ++-
>  scripts/tracetool/backend/ftrace.py   |  3 ---
>  scripts/tracetool/backend/log.py      |  9 +--------
>  scripts/tracetool/backend/simple.py   | 11 +----------
>  scripts/tracetool/backend/syslog.py   | 11 +----------
>  scripts/tracetool/backend/ust.py      |  2 +-
>  scripts/tracetool/format/h.py         | 13 +++++++++----
>  8 files changed, 18 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2025-06-17 15:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 20:12 [PATCH 0/3] tracetool:cleanup "if(true)" check from trace_foo() Tanish Desai
2025-06-16 20:12 ` [PATCH 1/3] tracetool: removed the unused vcpu property Tanish Desai
2025-06-17 14:07   ` Stefan Hajnoczi
2025-06-17 18:36     ` [PATCH v2] " Tanish Desai
2025-06-17 19:43   ` [PATCH 1/3] " Alex Bennée
2025-06-16 20:12 ` [PATCH 2/3] tracetool: introduce generate_unconditional Tanish Desai
2025-06-17 22:42   ` Alex Bennée
2025-06-18 16:23     ` Tanish Desai
2025-06-16 20:12 ` [PATCH 3/3] tracetool: remove redundant event_get_state checks Tanish Desai
2025-06-17 14:09 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250617140927.GB117267@fedora \
    --to=stefanha@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mads@ynddal.dk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tanishdesai37@gmail.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.