All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Timothy Pearson <tpearson@raptorengineering.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
	mahesh <mahesh@linux.ibm.com>, Oliver <oohall@gmail.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v10] PCI: Add pcie_link_is_active() function
Date: Tue, 17 Jun 2025 11:04:28 -0500	[thread overview]
Message-ID: <20250617160428.GA1137986@bhelgaas> (raw)
In-Reply-To: <988492931.1308196.1750174918075.JavaMail.zimbra@raptorengineeringinc.com>

On Tue, Jun 17, 2025 at 10:41:58AM -0500, Timothy Pearson wrote:
> Add pcie_link_is_active() function to check if the physical PCIe link is
> active, replacing duplicate code in multiple locations.
> 
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>

Whoa, whoa, slow down.  This doesn't address all the things I
mentioned (EXPORT_SYMBOL, for example).  But four postings in 90
minutes is way too much.  There's no hurry, everybody has other things
to do, and we can only assimilate a reposting every few days.  That
way others have a chance to respond with additional feedback, and you
can address it all at once.

When you do post an updated version, consider adding a brief changelog
(e.g., what changed between v8 and v9) below the "---" line so we know
what to look for.

> +EXPORT_SYMBOL(pcie_link_is_active);

  reply	other threads:[~2025-06-17 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 15:41 [PATCH v10] PCI: Add pcie_link_is_active() function Timothy Pearson
2025-06-17 16:04 ` Bjorn Helgaas [this message]
2025-06-17 16:10   ` Timothy Pearson
2025-06-17 18:59     ` Bjorn Helgaas
2025-06-17 19:19       ` Timothy Pearson
2025-06-17 20:02         ` Bjorn Helgaas
2025-06-17 16:16 ` Timothy Pearson
2025-06-19 13:55 ` Lukas Wunner
2025-08-26  7:04 ` Krishna Chaitanya Chundru
2025-08-26 12:48   ` Timothy Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250617160428.GA1137986@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=maddy@linux.ibm.com \
    --cc=mahesh@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=oohall@gmail.com \
    --cc=tpearson@raptorengineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.