From: Jakub Kicinski <kuba@kernel.org>
To: Jun Miao <jun.miao@intel.com>
Cc: sbhatta@marvell.com, oneukum@suse.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
qiang.zhang@linux.dev
Subject: Re: [PATCH v4] net: usb: Convert tasklet API to new bottom half workqueue mechanism
Date: Tue, 17 Jun 2025 16:22:13 -0700 [thread overview]
Message-ID: <20250617162213.45d693a8@kernel.org> (raw)
In-Reply-To: <20250615015315.2535159-1-jun.miao@intel.com>
On Sun, 15 Jun 2025 09:53:15 +0800 Jun Miao wrote:
> -static void usbnet_bh_tasklet(struct tasklet_struct *t)
> +static void usbnet_bh_workqueue(struct work_struct *work)
> {
> - struct usbnet *dev = from_tasklet(dev, t, bh);
> + struct usbnet *dev = from_work(dev, work, bh_work);
>
> usbnet_bh(&dev->delay);
> }
> @@ -1742,7 +1742,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> skb_queue_head_init (&dev->txq);
> skb_queue_head_init (&dev->done);
> skb_queue_head_init(&dev->rxq_pause);
> - tasklet_setup(&dev->bh, usbnet_bh_tasklet);
> + INIT_WORK(&dev->bh_work, usbnet_bh_workqueue);
workqueue is the queue, here we're talking about the work entry.
And we use the system workqueue to schedule on (system_bh_wq)
Please replace the workqueue with work here and in the comments
next prev parent reply other threads:[~2025-06-17 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 1:53 [PATCH v4] net: usb: Convert tasklet API to new bottom half workqueue mechanism Jun Miao
2025-06-16 6:03 ` Subbaraya Sundeep
2025-06-17 23:22 ` Jakub Kicinski [this message]
2025-06-18 1:41 ` Miao, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617162213.45d693a8@kernel.org \
--to=kuba@kernel.org \
--cc=jun.miao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=qiang.zhang@linux.dev \
--cc=sbhatta@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.