From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: mst@redhat.com, jasowang@redhat.com, eperezma@redhat.com,
kvm@vger.kernel.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] vhost: Fix typos in comments and clarity on alignof usage
Date: Tue, 17 Jun 2025 19:37:41 +0100 [thread overview]
Message-ID: <20250617183741.GD2545@horms.kernel.org> (raw)
In-Reply-To: <20250615173933.1610324-1-alok.a.tiwari@oracle.com>
On Sun, Jun 15, 2025 at 10:39:11AM -0700, Alok Tiwari wrote:
> This patch fixes multiple typos and improves comment clarity across
> vhost.c.
> - Correct spelling errors: "thead" -> "thread", "RUNNUNG" -> "RUNNING"
> and "available".
> - Improve comment by replacing informal comment ("Supersize me!")
> with a clear description.
> - Use __alignof__ correctly on dereferenced pointer types for better
> readability and alignment with kernel documentation.
Could you expand on the last point?
I see that the patch uses __alignof__ with rather than without parentheses.
But I don't follow how that corresponds with the comment above.
>
> These changes enhance code readability and maintainability.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
...
> @@ -1898,8 +1898,8 @@ static long vhost_vring_set_addr(struct vhost_dev *d,
> return -EFAULT;
>
> /* Make sure it's safe to cast pointers to vring types. */
> - BUILD_BUG_ON(__alignof__ *vq->avail > VRING_AVAIL_ALIGN_SIZE);
> - BUILD_BUG_ON(__alignof__ *vq->used > VRING_USED_ALIGN_SIZE);
> + BUILD_BUG_ON(__alignof__(*vq->avail) > VRING_AVAIL_ALIGN_SIZE);
> + BUILD_BUG_ON(__alignof__(*vq->used) > VRING_USED_ALIGN_SIZE);
> if ((a.avail_user_addr & (VRING_AVAIL_ALIGN_SIZE - 1)) ||
> (a.used_user_addr & (VRING_USED_ALIGN_SIZE - 1)) ||
> (a.log_guest_addr & (VRING_USED_ALIGN_SIZE - 1)))
...
next prev parent reply other threads:[~2025-06-17 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 17:39 [PATCH] vhost: Fix typos in comments and clarity on alignof usage Alok Tiwari
2025-06-17 18:37 ` Simon Horman [this message]
2025-06-17 20:01 ` ALOK TIWARI
2025-06-18 12:31 ` Simon Horman
2025-07-16 13:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617183741.GD2545@horms.kernel.org \
--to=horms@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.