From: kernel test robot <lkp@intel.com>
To: Bertrand Wlodarczyk <bertrand.wlodarczyk@intel.com>,
tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Bertrand Wlodarczyk <bertrand.wlodarczyk@intel.com>
Subject: Re: [PATCH] cgroup/rstat: change cgroup_base_stat to atomic
Date: Tue, 17 Jun 2025 20:38:55 +0800 [thread overview]
Message-ID: <202506172020.kFkGyrEE-lkp@intel.com> (raw)
In-Reply-To: <20250617102644.752201-2-bertrand.wlodarczyk@intel.com>
Hi Bertrand,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tj-cgroup/for-next]
[also build test WARNING on linus/master v6.16-rc2 next-20250617]
[cannot apply to trace/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bertrand-Wlodarczyk/cgroup-rstat-change-cgroup_base_stat-to-atomic/20250617-183242
base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
patch link: https://lore.kernel.org/r/20250617102644.752201-2-bertrand.wlodarczyk%40intel.com
patch subject: [PATCH] cgroup/rstat: change cgroup_base_stat to atomic
config: arc-randconfig-001-20250617 (https://download.01.org/0day-ci/archive/20250617/202506172020.kFkGyrEE-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250617/202506172020.kFkGyrEE-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506172020.kFkGyrEE-lkp@intel.com/
All warnings (new ones prefixed by >>):
kernel/cgroup/rstat.c: In function 'css_rstat_init':
>> kernel/cgroup/rstat.c:415:55: warning: variable 'rstatbc' set but not used [-Wunused-but-set-variable]
415 | struct cgroup_rstat_base_cpu *rstatbc;
| ^~~~~~~
kernel/cgroup/rstat.c: In function 'root_cgroup_cputime':
kernel/cgroup/rstat.c:629:42: error: passing argument 2 of 'atomic64_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
629 | atomic64_add(sys + user, &cputime->sum_exec_runtime);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| atomic_long_t * {aka atomic_t *}
In file included from include/linux/atomic.h:82,
from include/asm-generic/bitops/lock.h:5,
from arch/arc/include/asm/bitops.h:188,
from include/linux/bitops.h:67,
from include/linux/thread_info.h:27,
from include/linux/sched.h:14,
from include/linux/cgroup.h:12,
from kernel/cgroup/cgroup-internal.h:5,
from kernel/cgroup/rstat.c:2:
include/linux/atomic/atomic-instrumented.h:1680:33: note: expected 'atomic64_t *' but argument is of type 'atomic_long_t *' {aka 'atomic_t *'}
1680 | atomic64_add(s64 i, atomic64_t *v)
| ~~~~~~~~~~~~^
In file included from ./arch/arc/include/generated/asm/div64.h:1,
from include/linux/math.h:6,
from include/linux/kernel.h:27,
from include/linux/cpumask.h:11,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/spinlock.h:63,
from include/linux/sched.h:2209,
from include/linux/cgroup.h:12,
from kernel/cgroup/cgroup-internal.h:5,
from kernel/cgroup/rstat.c:2:
kernel/cgroup/rstat.c: In function 'cgroup_base_stat_cputime_show':
include/asm-generic/div64.h:183:35: warning: comparison of distinct pointer types lacks a cast
183 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ^~
kernel/cgroup/rstat.c:677:9: note: in expansion of macro 'do_div'
677 | do_div(utime, NSEC_PER_USEC);
| ^~~~~~
include/asm-generic/div64.h:183:35: warning: comparison of distinct pointer types lacks a cast
183 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ^~
kernel/cgroup/rstat.c:681:9: note: in expansion of macro 'do_div'
681 | do_div(stime, NSEC_PER_USEC);
| ^~~~~~
include/asm-generic/div64.h:183:35: warning: comparison of distinct pointer types lacks a cast
183 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ^~
kernel/cgroup/rstat.c:685:9: note: in expansion of macro 'do_div'
685 | do_div(ntime, NSEC_PER_USEC);
| ^~~~~~
cc1: some warnings being treated as errors
vim +/rstatbc +415 kernel/cgroup/rstat.c
a17556f8d9798e Tejun Heo 2018-04-26 380
a97915559f5c5f JP Kobryn 2025-04-03 381 int css_rstat_init(struct cgroup_subsys_state *css)
a17556f8d9798e Tejun Heo 2018-04-26 382 {
a97915559f5c5f JP Kobryn 2025-04-03 383 struct cgroup *cgrp = css->cgroup;
a17556f8d9798e Tejun Heo 2018-04-26 384 int cpu;
5da3bfa029d680 JP Kobryn 2025-05-14 385 bool is_self = css_is_self(css);
a17556f8d9798e Tejun Heo 2018-04-26 386
5da3bfa029d680 JP Kobryn 2025-05-14 387 if (is_self) {
5da3bfa029d680 JP Kobryn 2025-05-14 388 /* the root cgrp has rstat_base_cpu preallocated */
5da3bfa029d680 JP Kobryn 2025-05-14 389 if (!cgrp->rstat_base_cpu) {
5da3bfa029d680 JP Kobryn 2025-05-14 390 cgrp->rstat_base_cpu = alloc_percpu(struct cgroup_rstat_base_cpu);
5da3bfa029d680 JP Kobryn 2025-05-14 391 if (!cgrp->rstat_base_cpu)
a17556f8d9798e Tejun Heo 2018-04-26 392 return -ENOMEM;
a17556f8d9798e Tejun Heo 2018-04-26 393 }
5da3bfa029d680 JP Kobryn 2025-05-14 394 } else if (css->ss->css_rstat_flush == NULL)
5da3bfa029d680 JP Kobryn 2025-05-14 395 return 0;
5da3bfa029d680 JP Kobryn 2025-05-14 396
5da3bfa029d680 JP Kobryn 2025-05-14 397 /* the root cgrp's self css has rstat_cpu preallocated */
5da3bfa029d680 JP Kobryn 2025-05-14 398 if (!css->rstat_cpu) {
5da3bfa029d680 JP Kobryn 2025-05-14 399 css->rstat_cpu = alloc_percpu(struct css_rstat_cpu);
5da3bfa029d680 JP Kobryn 2025-05-14 400 if (!css->rstat_cpu) {
5da3bfa029d680 JP Kobryn 2025-05-14 401 if (is_self)
5da3bfa029d680 JP Kobryn 2025-05-14 402 free_percpu(cgrp->rstat_base_cpu);
a17556f8d9798e Tejun Heo 2018-04-26 403
f6e9a26e2d488c JP Kobryn 2025-04-03 404 return -ENOMEM;
f6e9a26e2d488c JP Kobryn 2025-04-03 405 }
f6e9a26e2d488c JP Kobryn 2025-04-03 406 }
f6e9a26e2d488c JP Kobryn 2025-04-03 407
a17556f8d9798e Tejun Heo 2018-04-26 408 /* ->updated_children list is self terminated */
a17556f8d9798e Tejun Heo 2018-04-26 409 for_each_possible_cpu(cpu) {
5da3bfa029d680 JP Kobryn 2025-05-14 410 struct css_rstat_cpu *rstatc = css_rstat_cpu(css, cpu);
5da3bfa029d680 JP Kobryn 2025-05-14 411
5da3bfa029d680 JP Kobryn 2025-05-14 412 rstatc->updated_children = css;
a17556f8d9798e Tejun Heo 2018-04-26 413
5da3bfa029d680 JP Kobryn 2025-05-14 414 if (is_self) {
5da3bfa029d680 JP Kobryn 2025-05-14 @415 struct cgroup_rstat_base_cpu *rstatbc;
5da3bfa029d680 JP Kobryn 2025-05-14 416
5da3bfa029d680 JP Kobryn 2025-05-14 417 rstatbc = cgroup_rstat_base_cpu(cgrp, cpu);
a17556f8d9798e Tejun Heo 2018-04-26 418 }
5da3bfa029d680 JP Kobryn 2025-05-14 419 }
a17556f8d9798e Tejun Heo 2018-04-26 420
a17556f8d9798e Tejun Heo 2018-04-26 421 return 0;
a17556f8d9798e Tejun Heo 2018-04-26 422 }
a17556f8d9798e Tejun Heo 2018-04-26 423
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-06-17 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 10:26 [PATCH] cgroup/rstat: change cgroup_base_stat to atomic Bertrand Wlodarczyk
2025-06-17 12:38 ` kernel test robot [this message]
2025-06-17 13:16 ` Michal Koutný
2025-06-18 14:31 ` Wlodarczyk, Bertrand
2025-06-17 13:32 ` kernel test robot
2025-06-17 21:05 ` JP Kobryn
2025-06-18 16:05 ` Wlodarczyk, Bertrand
2025-06-18 17:17 ` Shakeel Butt
2025-06-18 17:21 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506172020.kFkGyrEE-lkp@intel.com \
--to=lkp@intel.com \
--cc=bertrand.wlodarczyk@intel.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.