From: Kuniyuki Iwashima <kuni1840@gmail.com>
To: dw@davidwei.uk
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, horms@kernel.org, kuba@kernel.org,
kuni1840@gmail.com, ncardwell@google.com, netdev@vger.kernel.org,
pabeni@redhat.com, shuah@kernel.org,
Kuniyuki Iwashima <kuniyu@google.com>
Subject: Re: [PATCH net v2 4/4] tcp: fix passive TFO socket having invalid NAPI ID
Date: Tue, 17 Jun 2025 14:29:44 -0700 [thread overview]
Message-ID: <20250617212952.1914360-1-kuni1840@gmail.com> (raw)
In-Reply-To: <20250617212102.175711-5-dw@davidwei.uk>
From: David Wei <dw@davidwei.uk>
Date: Tue, 17 Jun 2025 14:21:02 -0700
> There is a bug with passive TFO sockets returning an invalid NAPI ID 0
> from SO_INCOMING_NAPI_ID. Normally this is not an issue, but zero copy
> receive relies on a correct NAPI ID to process sockets on the right
> queue.
>
> Fix by adding a sk_mark_napi_id_set().
>
> Fixes: e5907459ce7e ("tcp: Record Rx hash and NAPI ID in tcp_child_process")
> Signed-off-by: David Wei <dw@davidwei.uk>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
next prev parent reply other threads:[~2025-06-17 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 21:20 [PATCH net v2 0/4] net: fix passive TFO socket having invalid NAPI ID David Wei
2025-06-17 21:20 ` [PATCH net v2 1/4] selftests: netdevsim: improve lib.sh include in peer.sh David Wei
2025-06-17 21:21 ` [PATCH net v2 2/4] selftests: net: add passive TFO test binary David Wei
2025-06-17 21:21 ` [PATCH net v2 3/4] selftests: net: add test for passive TFO socket NAPI ID David Wei
2025-06-17 21:21 ` [PATCH net v2 4/4] tcp: fix passive TFO socket having invalid " David Wei
2025-06-17 21:29 ` Kuniyuki Iwashima [this message]
2025-06-18 8:11 ` Eric Dumazet
2025-06-19 2:20 ` [PATCH net v2 0/4] net: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617212952.1914360-1-kuni1840@gmail.com \
--to=kuni1840@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.