All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Hamilton <adhamilt@gmail.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, rudi@heitbaum.com, phcoder@gmail.com,
	Andrew Hamilton <adhamilt@gmail.com>
Subject: [PATCH v2 0/2] Correct Build Failures with GCC-15 and CLANG
Date: Tue, 17 Jun 2025 20:58:24 -0500	[thread overview]
Message-ID: <20250618015826.270234-1-adhamilt@gmail.com> (raw)

1. Correct GRUB build with GCC >= 15 due to new GNULIB compile
warning detected by GCC.

Pull in gnulib fix to allow base64.c to compile using GCC 15 or newer.

Pulled from: GNULIB commit 25df6dc4253480a343dde3376ce6fd99c316a532

GCC 15 adds a new compiler warning "-Wunterminated-string-initialization"
that will trigger what is considered a false-positive in base64.c as this
array is not treated as a string but an array of characters so the lack
of NULL string terminator is expected.

GCC team has added ability to flag such instances of arrays that the
compiler may think are strings as "nonstring" arrays to avoid this
warning: _attribute_((nonstring)). Reference this GCC discussion
for more details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178

Tested that the compile now succeeds using current mainline development
GCC, build still works with GCC 12.2.0, and build still works with CLANG
14.0.6.

Fixes: https://savannah.gnu.org/bugs/?66470

2. Correct GRUB build with CLANG due to a regression in grub-protect.c

util/grub-protect: Correct uninit 'err' Variable

In function protect_tpm2_export_tpm2key, the 'err' variable
is uninitialized in the normal (error free) path, so ensure this
defaults to GRUB_ERR_NONE.

This causes the GRUB build to fail with clang (observed with
clang-14).

Fixes:  5934bf51c (util/grub-protect: Support NV index mode)

Changes since v1:
 - Rebased patches against current master

Andrew Hamilton (2):
  gnulib: Add patch to allow GRUB w/GCC-15 compile
  util/grub-protect: Correct uninit 'err' Variable

 bootstrap.conf                                        |  3 ++-
 grub-core/lib/gnulib-patches/gcc-15-compile-fix.patch | 11 +++++++++++
 util/grub-protect.c                                   |  2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 grub-core/lib/gnulib-patches/gcc-15-compile-fix.patch

-- 
2.39.5


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

             reply	other threads:[~2025-06-18  1:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18  1:58 Andrew Hamilton [this message]
2025-06-18  1:58 ` [PATCH v2 1/2] gnulib: Add patch to allow GRUB w/GCC-15 compile Andrew Hamilton
2025-06-18  5:06   ` sudhakar
2025-06-18  1:58 ` [PATCH v2 2/2] util/grub-protect: Correct uninit 'err' Variable Andrew Hamilton
2025-06-18  4:40   ` sudhakar
2025-06-18 14:19 ` [PATCH v2 0/2] Correct Build Failures with GCC-15 and CLANG Daniel Kiper via Grub-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250618015826.270234-1-adhamilt@gmail.com \
    --to=adhamilt@gmail.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=phcoder@gmail.com \
    --cc=rudi@heitbaum.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.