All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: pip-izony <eeodqql09@gmail.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: xhci-plat: fix incorrect type for of_match variable in xhci_plat_probe()
Date: Wed, 18 Jun 2025 08:02:38 +0200	[thread overview]
Message-ID: <2025061804-existing-taking-1f9c@gregkh> (raw)
In-Reply-To: <20250617204500.346984-1-eeodqql09@gmail.com>

On Tue, Jun 17, 2025 at 04:45:00PM -0400, pip-izony wrote:
> The variable `of_match` was incorrectly declared as a `bool`.
> It is assigned the return value of of_match_device(), which is a pointer of
> type `const struct of_device_id *`.
> 
> Signed-off-by: pip-izony <eeodqql09@gmail.com>

We need a real name here, please.

Also, what commit id does this fix?

And finally, how is this even building if the type is wrong?

confused,

greg k-h

  reply	other threads:[~2025-06-18  6:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 20:45 [PATCH] usb: host: xhci-plat: fix incorrect type for of_match variable in xhci_plat_probe() pip-izony
2025-06-18  6:02 ` Greg Kroah-Hartman [this message]
2025-06-18 19:27   ` Seungjin Bae
2025-06-19  4:01     ` Greg Kroah-Hartman
2025-06-19  5:45       ` [PATCH v3] " Seungjin Bae
2025-06-19  5:57       ` [PATCH v4] " Seungjin Bae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025061804-existing-taking-1f9c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=eeodqql09@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.