From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E9E2C7115D for ; Wed, 18 Jun 2025 13:03:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D26EE10E1F5; Wed, 18 Jun 2025 13:03:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.b="IOuQkJst"; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D18B10E7B0 for ; Wed, 18 Jun 2025 09:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CGb5mKZOnT8l3nM3LFP8GEL7DzYf8In3iy0gEpFOfVE=; b=IOuQkJstZSJKMRjLrPcD/6kFw5 eOTx1uOeQpE55bT4O+spQ35PABNBCea6TxH4DuyrMMAODVirtUXRazj3Gln03D8NBd4KT7zBDBq/q Ezb3Nt9xJZ9du1BMVBSIyAroZQxvV7kNsmpc+OGHUT47I7NJu9cl8QyQoZtmziFMBjeIHK4V2banW enXCnoAi4QU4pYMjlVZC6RHUGpGDppK6xEOd95d400e4+2ecns2cphMIR215JxWD56m3eAGSX22YL XHUV+cV1IIX4S3kB67oPwTKHsv5BSuQhq1AozCSNkdLyrQEesTZL7q7Znxpu7bIFtpDcVMcAZp8sk +AaYuLiA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRoqP-00000002XjI-2nVh; Wed, 18 Jun 2025 09:12:33 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id A6957307D9B; Wed, 18 Jun 2025 11:12:32 +0200 (CEST) Date: Wed, 18 Jun 2025 11:12:32 +0200 From: Peter Zijlstra To: Mario Limonciello , bhe@redhat.com Cc: Christian =?iso-8859-1?Q?K=F6nig?= , alexander.deucher@amd.com, Borislav Petkov , amd-gfx@lists.freedesktop.org Subject: Re: amdgpu vs kexec Message-ID: <20250618091232.GD1613633@noisy.programming.kicks-ass.net> References: <20250616093945.GA1613200@noisy.programming.kicks-ass.net> <4f5f95ff-b97e-41db-b9fd-5204e6581a30@amd.com> <20250616145437.GG1613376@noisy.programming.kicks-ass.net> <2bbcc44d-9079-4a73-ba6c-e93fdcb9cf6f@kernel.org> <20250618085123.GF1613376@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618085123.GF1613376@noisy.programming.kicks-ass.net> X-Mailman-Approved-At: Wed, 18 Jun 2025 13:03:09 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Jun 18, 2025 at 10:51:23AM +0200, Peter Zijlstra wrote: > On Tue, Jun 17, 2025 at 09:12:12PM -0500, Mario Limonciello wrote: > > > How about if we reset before the kexec? There is a symbol for drivers to > > use to know they're about to go through kexec to do $THINGS. > > > > Something like this: > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > index 0fc0eeedc6461..2b1216b14d618 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > @@ -34,6 +34,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -2544,6 +2545,9 @@ amdgpu_pci_shutdown(struct pci_dev *pdev) > > adev->mp1_state = PP_MP1_STATE_UNLOAD; > > amdgpu_device_ip_suspend(adev); > > adev->mp1_state = PP_MP1_STATE_NONE; > > + > > + if (kexec_in_progress) > > + amdgpu_asic_reset(adev); > > } > > > > static int amdgpu_pmops_prepare(struct device *dev) > > I will throw this in the dev kernel... I'll let you know. First hurdle appears to be that this symbol is not exported. I fixed that, but perhaps the kexec folks don't like drivers to use this?