Re: [PATCH net-next 4/9] net: ethtool: add dedicated callbacks for getting and setting rxfh fields

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 18 Jun 2025 20:25:24 +0300 Dan Carpenter wrote:
> 65107e14ebb8971 net/ethtool/ioctl.c Jakub Kicinski  2025-06-11 @1530  	if ((!ops->get_rxnfc && !ops->get_rxfh_fields) || !ops->set_rxfh)
>                                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Imagine ops->get_rxnfc is NULL but ops->get_rxfh_fields is not
> and also ops->set_rxfh is not.  Seems unlikely...

> 3de0b592394d17b net/core/ethtool.c  Venkata Duvvuru 2014-04-21  1591  	rx_rings.cmd = ETHTOOL_GRXRINGS;
> 3de0b592394d17b net/core/ethtool.c  Venkata Duvvuru 2014-04-21 @1592  	ret = ops->get_rxnfc(dev, &rx_rings, NULL);
> 
> Then this would be a NULL dereference.  There is no way we succeed
> when ops->get_rxnfc is NULL.

Ack, thanks! There is some compat code here that will be gone once 
I convert all the drivers (hopefully by Friday). I'll fix it when
removing the compat.