All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Paul Chaignon <paul.chaignon@gmail.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH stable 5.10,5.15 1/2] net: Fix checksum update for ILA adj-transport
Date: Thu, 19 Jun 2025 05:04:09 -0400	[thread overview]
Message-ID: <20250618131323-5e8ae3a33ddd577d@stable.kernel.org> (raw)
In-Reply-To: <0bd9e0321544730642e1b068dd70178d5a3f8804.1750171422.git.paul.chaignon@gmail.com>

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 6043b794c7668c19dabc4a93c75b924a19474d59

Status in newer kernel trees:
6.15.y | Present (different SHA1: ce211a9d9fc1)
6.12.y | Present (different SHA1: 0de96086526a)
6.6.y | Present (different SHA1: 5dd8c050f1bc)
6.1.y | Present (different SHA1: 9dc3a16a1abb)
5.15.y | Not found

Note: The patch differs from the upstream commit:
---
1:  6043b794c7668 ! 1:  7f3475830b70a net: Fix checksum update for ILA adj-transport
    @@ Metadata
      ## Commit message ##
         net: Fix checksum update for ILA adj-transport
     
    +    [ Upstream commit 6043b794c7668c19dabc4a93c75b924a19474d59 ]
    +    [ Note: Fixed conflict due to unrelated change in
    +      inet_proto_csum_replace_by_diff. ]
    +
         During ILA address translations, the L4 checksums can be handled in
         different ways. One of them, adj-transport, consist in parsing the
         transport layer and updating any found checksum. This logic relies on
    @@ Commit message
         Acked-by: Daniel Borkmann <daniel@iogearbox.net>
         Link: https://patch.msgid.link/b5539869e3550d46068504feb02d37653d939c0b.1748509484.git.paul.chaignon@gmail.com
         Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    +    Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
     
      ## include/net/checksum.h ##
     @@ include/net/checksum.h: void inet_proto_csum_replace16(__sum16 *sum, struct sk_buff *skb,
    @@ net/core/utils.c: void inet_proto_csum_replace16(__sum16 *sum, struct sk_buff *s
     +				     __wsum diff, bool pseudohdr, bool ipv6)
      {
      	if (skb->ip_summed != CHECKSUM_PARTIAL) {
    - 		csum_replace_by_diff(sum, diff);
    + 		*sum = csum_fold(csum_add(diff, ~csum_unfold(*sum)));
     -		if (skb->ip_summed == CHECKSUM_COMPLETE && pseudohdr)
     +		if (skb->ip_summed == CHECKSUM_COMPLETE && pseudohdr && !ipv6)
    - 			skb->csum = ~csum_sub(diff, skb->csum);
    + 			skb->csum = ~csum_add(diff, ~skb->csum);
      	} else if (pseudohdr) {
      		*sum = ~csum_fold(csum_add(diff, csum_unfold(*sum)));
     
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.15.y       |  Success    |  Success   |

      parent reply	other threads:[~2025-06-19  9:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 15:48 [PATCH stable 5.10,5.15 1/2] net: Fix checksum update for ILA adj-transport Paul Chaignon
2025-06-17 15:49 ` [PATCH stable 5.10,5.15 2/2] bpf: Fix L4 csum update on IPv6 in CHECKSUM_COMPLETE Paul Chaignon
2025-06-19  9:02   ` Sasha Levin
2025-06-23  8:46   ` Greg Kroah-Hartman
2025-06-23  9:04     ` Paul Chaignon
2025-06-23  9:13       ` Greg Kroah-Hartman
2025-06-19  9:04 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250618131323-5e8ae3a33ddd577d@stable.kernel.org \
    --to=sashal@kernel.org \
    --cc=paul.chaignon@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.