From: Tom Rini <trini@konsulko.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: jerome.forissier@linaro.org, mikko.rapeli@linaro.org,
"Rayagonda Kokatanur" <rayagonda.kokatanur@broadcom.com>,
"Tuomas Tynkkynen" <tuomas.tynkkynen@iki.fi>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Casey Connolly" <casey.connolly@linaro.org>,
"Tien Fong Chee" <tien.fong.chee@altera.com>,
"Patrick Rudolph" <patrick.rudolph@9elements.com>,
"Simon Glass" <sjg@chromium.org>,
"Boyan Karatotev" <boyan.karatotev@arm.com>,
"Alif Zakuan Yuslaimi" <alif.zakuan.yuslaimi@intel.com>,
"Oliver Gaskell" <Oliver.Gaskell@analog.com>,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
"Liya Huang" <1425075683@qq.com>,
"Raymond Mao" <raymond.mao@linaro.org>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Venkatesh Yadav Abbarapu" <venkatesh.abbarapu@amd.com>,
"Ashok Reddy Soma" <ashok.reddy.soma@amd.com>,
"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2 1/3] nxp: Prepare macros for KVM changes
Date: Wed, 18 Jun 2025 08:07:29 -0600 [thread overview]
Message-ID: <20250618140729.GD6521@bill-the-cat> (raw)
In-Reply-To: <20250618065828.1312146-2-ilias.apalodimas@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On Wed, Jun 18, 2025 at 09:58:12AM +0300, Ilias Apalodimas wrote:
> A following patch is replacing our IO accessors with
> do { ... } while(0) ones in order to make them usable with KVM.
>
> That leads to an error eventually looking like this:
> arch/arm/include/asm/io.h:62:9: error: expected expression before 'do'
> 62 | do { \
> | ^~
> arch/arm/include/asm/io.h:211:41: note: in expansion of macro '__raw_writel'
> 211 | #define out_arch(type,endian,a,v) __raw_write##type(cpu_to_##endian(v),a)
> | ^~~~~~~~~~~
> arch/arm/include/asm/io.h:223:25: note: in expansion of macro 'out_arch'
> 223 | #define out_be32(a,v) out_arch(l,be32,a,v)
> | ^~~~~~~~
> drivers/spi/fsl_dspi.c:127:17: note: in expansion of macro 'out_be32'
> 127 | out_be32(addr, val) : out_le32(addr, val);
> | ^~~~~~~~
>
> So adjust the current macros and code to be compatible with the upcoming
> change.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-06-18 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 6:58 [PATCH v2 0/3] Fix io accessors for KVM Ilias Apalodimas
2025-06-18 6:58 ` [PATCH v2 1/3] nxp: Prepare macros for KVM changes Ilias Apalodimas
2025-06-18 14:07 ` Tom Rini [this message]
2025-06-18 6:58 ` [PATCH v2 2/3] arm: io.h: Fix io accessors for KVM Ilias Apalodimas
2025-06-18 6:58 ` [PATCH v2 3/3] qemu: arm: Enable virtualizable IO accessors Ilias Apalodimas
2025-06-18 9:59 ` [PATCH v2 0/3] Fix io accessors for KVM Mikko Rapeli
2025-06-18 11:03 ` Jerome Forissier
2025-06-18 12:04 ` Ilias Apalodimas
2025-06-27 19:10 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618140729.GD6521@bill-the-cat \
--to=trini@konsulko.com \
--cc=1425075683@qq.com \
--cc=Oliver.Gaskell@analog.com \
--cc=alif.zakuan.yuslaimi@intel.com \
--cc=ashok.reddy.soma@amd.com \
--cc=boyan.karatotev@arm.com \
--cc=casey.connolly@linaro.org \
--cc=duje.mihanovic@skole.hr \
--cc=ilias.apalodimas@linaro.org \
--cc=jagan@amarulasolutions.com \
--cc=jerome.forissier@linaro.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mikko.rapeli@linaro.org \
--cc=patrick.delaunay@foss.st.com \
--cc=patrick.rudolph@9elements.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=raymond.mao@linaro.org \
--cc=sjg@chromium.org \
--cc=tien.fong.chee@altera.com \
--cc=tuomas.tynkkynen@iki.fi \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.