All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2 09/10] PM: EM: Implement em_notify_pd_created/updated().
Date: Wed, 18 Jun 2025 17:54:32 +0800	[thread overview]
Message-ID: <202506181708.P4eRyPUC-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250613094428.267791-10-changwoo@igalia.com>
References: <20250613094428.267791-10-changwoo@igalia.com>
TO: Changwoo Min <changwoo@igalia.com>
TO: lukasz.luba@arm.com
TO: rafael@kernel.org
TO: len.brown@intel.com
TO: pavel@kernel.org
CC: christian.loehle@arm.com
CC: tj@kernel.org
CC: kernel-dev@igalia.com
CC: linux-pm@vger.kernel.org
CC: sched-ext@lists.linux.dev
CC: linux-kernel@vger.kernel.org
CC: Changwoo Min <changwoo@igalia.com>

Hi Changwoo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.16-rc2 next-20250618]
[cannot apply to amd-pstate/linux-next amd-pstate/bleeding-edge]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Changwoo-Min/PM-EM-Add-em-yaml-and-autogen-files/20250613-174859
base:   linus/master
patch link:    https://lore.kernel.org/r/20250613094428.267791-10-changwoo%40igalia.com
patch subject: [PATCH v2 09/10] PM: EM: Implement em_notify_pd_created/updated().
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-randconfig-161-20250618 (https://download.01.org/0day-ci/archive/20250618/202506181708.P4eRyPUC-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202506181708.P4eRyPUC-lkp@intel.com/

smatch warnings:
kernel/power/em_netlink.c:249 __em_notify_pd_table() error: uninitialized symbol 'ret'.

vim +/ret +249 kernel/power/em_netlink.c

24b309699bc739 Changwoo Min 2025-06-13  215  
b0668476cf48ef Changwoo Min 2025-06-13  216  
b0668476cf48ef Changwoo Min 2025-06-13  217  /**************************** Event encoding *********************************/
76ab710f256a78 Changwoo Min 2025-06-13  218  static int __em_notify_pd_table(const struct em_perf_domain *pd, int ntf_type)
76ab710f256a78 Changwoo Min 2025-06-13  219  {
76ab710f256a78 Changwoo Min 2025-06-13  220  	struct sk_buff *msg;
76ab710f256a78 Changwoo Min 2025-06-13  221  	int msg_sz, ret;
76ab710f256a78 Changwoo Min 2025-06-13  222  	void *hdr;
76ab710f256a78 Changwoo Min 2025-06-13  223  
76ab710f256a78 Changwoo Min 2025-06-13  224  	if (!genl_has_listeners(&em_nl_family, &init_net, EM_NLGRP_EVENT))
76ab710f256a78 Changwoo Min 2025-06-13  225  		return 0;
76ab710f256a78 Changwoo Min 2025-06-13  226  
76ab710f256a78 Changwoo Min 2025-06-13  227  	msg_sz = __em_nl_get_pd_table_size(pd);
76ab710f256a78 Changwoo Min 2025-06-13  228  
76ab710f256a78 Changwoo Min 2025-06-13  229  	msg = genlmsg_new(msg_sz, GFP_KERNEL);
76ab710f256a78 Changwoo Min 2025-06-13  230  	if (!msg)
76ab710f256a78 Changwoo Min 2025-06-13  231  		return -ENOMEM;
76ab710f256a78 Changwoo Min 2025-06-13  232  
76ab710f256a78 Changwoo Min 2025-06-13  233  	hdr = genlmsg_put(msg, 0, 0, &em_nl_family, 0, ntf_type);
76ab710f256a78 Changwoo Min 2025-06-13  234  	if (!hdr)
76ab710f256a78 Changwoo Min 2025-06-13  235  		goto out_free_msg;
76ab710f256a78 Changwoo Min 2025-06-13  236  
76ab710f256a78 Changwoo Min 2025-06-13  237  	ret = __em_nl_get_pd_table(msg, pd);
76ab710f256a78 Changwoo Min 2025-06-13  238  	if (ret)
76ab710f256a78 Changwoo Min 2025-06-13  239  		goto out_free_msg;
76ab710f256a78 Changwoo Min 2025-06-13  240  
76ab710f256a78 Changwoo Min 2025-06-13  241  	genlmsg_end(msg, hdr);
76ab710f256a78 Changwoo Min 2025-06-13  242  
76ab710f256a78 Changwoo Min 2025-06-13  243  	genlmsg_multicast(&em_nl_family, msg, 0, EM_NLGRP_EVENT, GFP_KERNEL);
76ab710f256a78 Changwoo Min 2025-06-13  244  
76ab710f256a78 Changwoo Min 2025-06-13  245  	return 0;
76ab710f256a78 Changwoo Min 2025-06-13  246  
76ab710f256a78 Changwoo Min 2025-06-13  247  out_free_msg:
76ab710f256a78 Changwoo Min 2025-06-13  248  	nlmsg_free(msg);
76ab710f256a78 Changwoo Min 2025-06-13 @249  	return ret;
76ab710f256a78 Changwoo Min 2025-06-13  250  }
76ab710f256a78 Changwoo Min 2025-06-13  251  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2025-06-18  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18  9:54 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-13  9:44 [PATCH v2 00/10] PM: EM: Add netlink support for the energy model Changwoo Min
2025-06-13  9:44 ` [PATCH v2 09/10] PM: EM: Implement em_notify_pd_created/updated() Changwoo Min
2025-06-13 20:02   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202506181708.P4eRyPUC-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.