From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
arkadiusz.kubalewski@intel.com
Subject: Re: [PATCH net] tools: ynl: fix mixing ops and notifications on one socket
Date: Thu, 19 Jun 2025 07:33:31 -0700 [thread overview]
Message-ID: <20250619073331.354a270a@kernel.org> (raw)
In-Reply-To: <m234bwgmss.fsf@gmail.com>
On Thu, 19 Jun 2025 09:25:55 +0100 Donald Hunter wrote:
> Good catch, fix LGTM. It looks like a followup refactor could combine
> annotate_extack and _decode_extack and get rid of the attr_space
> parameter to NlMsg(). WDYT?
Indeed, sounds like a step in the right direction!
extack is a tricky thing to fit into an object model :(
next prev parent reply other threads:[~2025-06-19 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 17:17 [PATCH net] tools: ynl: fix mixing ops and notifications on one socket Jakub Kicinski
2025-06-19 8:25 ` Donald Hunter
2025-06-19 14:33 ` Jakub Kicinski [this message]
2025-06-19 15:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619073331.354a270a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.