From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30FBE2045B1; Thu, 19 Jun 2025 10:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750328374; cv=none; b=axbEcMFtzmtgk+HrO83S0V6lvO/sggNeDr8nrNDg2HHaQ4razeTWuYJgN6W5Shelbgj3rZeYKtYw2Re5G1IgvFYm0YU3JzK5pV7MFmhwO62HW67pA1chaJsbEwziuc0R8be43lIM1IdP3BOJPUJYO9HSWQu5+mTpIUYZz3T9GYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750328374; c=relaxed/simple; bh=TFp8r10SI9qs2FkfzjhWNknAgkyWJ+OG/4m+bbmfhzk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l6GpdS6sB7qsD2qgmHr/4xXt3UdpO25YN10iPC9u/DXuUD1IQTRI4UpKAhF4qjrxv9Lj5dFJvojCuZ/Lf8wxsU4vrXvkqidVXpmKFoT/DGz4tRbcJgjKJ84cfex95qN9puL33QoSVg1Ss/E59noLV9ShIdq8qXX+gLDUfW/uLuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FfABfO1X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FfABfO1X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03FBCC4CEEA; Thu, 19 Jun 2025 10:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750328373; bh=TFp8r10SI9qs2FkfzjhWNknAgkyWJ+OG/4m+bbmfhzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FfABfO1XIqtf7KGj/5ngqcFzZKbitq+SeZIVFHF2gZUGBoyNcNayUNwFQMm5x04IX +Ii+ev4k0tjABdat5ReX41nuK7u7thzwEjcS5a7I49OrseK1ztIRmJUTn/NVR467yG kUPS75ydQ7srPjtgNFvFtw0yR9+7X4MaN1spsNgLVqIkLDJZJEgEtQz8xlbT12DDPY 2hwuxd69bb1wDs9vLdAHADsYJlqa/qS1nP47T9f77eT8MdrEdZsC1oxjLMdG/kIpUR ojXC3nTupjkK/rY7qxt+lCg+Vm4qnob1nZsXdwm3aL/24Zuo08RpghdmPkr5rt54d9 e4pLtUqQgCj7Q== Date: Thu, 19 Jun 2025 11:19:29 +0100 From: Simon Horman To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , jv@jvosburgh.ne, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gustavold@gmail.com Subject: Re: [PATCH 2/3] netpoll: extract IPv4 address retrieval into helper function Message-ID: <20250619101929.GF1699@horms.kernel.org> References: <20250618-netpoll_ip_ref-v1-0-c2ac00fe558f@debian.org> <20250618-netpoll_ip_ref-v1-2-c2ac00fe558f@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618-netpoll_ip_ref-v1-2-c2ac00fe558f@debian.org> On Wed, Jun 18, 2025 at 02:32:46AM -0700, Breno Leitao wrote: > Move the IPv4 address retrieval logic from netpoll_setup() into a > separate netpoll_take_ipv4() function to improve code organization > and readability. This change consolidates the IPv4-specific logic > and error handling into a dedicated function while maintaining > the same functionality. > > No functional changes. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman