From: Simon Horman <horms@kernel.org>
To: Wang Liang <wangliang74@huawei.com>
Cc: wenjia@linux.ibm.com, jaka@linux.ibm.com,
alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
guwen@linux.alibaba.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
yuehaibing@huawei.com, zhangchangzhong@huawei.com,
linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/smc: remove unused function smc_lo_supports_v2
Date: Thu, 19 Jun 2025 11:42:01 +0100 [thread overview]
Message-ID: <20250619104201.GI1699@horms.kernel.org> (raw)
In-Reply-To: <20250619030854.1536676-1-wangliang74@huawei.com>
On Thu, Jun 19, 2025 at 11:08:54AM +0800, Wang Liang wrote:
> The smcd_ops->supports_v2 is only called in smcd_register_dev(), which
> calls function smcd_supports_v2 for ism. For loopback-ism, function
> smc_lo_supports_v2 is unused, remove it.
>
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
Thanks, I agree with this analysis.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-06-19 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 3:08 [PATCH net-next] net/smc: remove unused function smc_lo_supports_v2 Wang Liang
2025-06-19 10:42 ` Simon Horman [this message]
2025-06-21 15:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619104201.GI1699@horms.kernel.org \
--to=horms@kernel.org \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wangliang74@huawei.com \
--cc=wenjia@linux.ibm.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.