Re: Re: [net-next v5 3/3] net: ethernet: mtk_eth_soc: skip first IRQ if not used

[Simon Horman <horms@kernel.org>]

On Thu, Jun 19, 2025 at 10:32:05AM +0000, Frank Wunderlich wrote:
> Hi Simon
> 
> > Gesendet: Donnerstag, 19. Juni 2025 um 12:03
> > Von: "Simon Horman" <horms@kernel.org>
> > Betreff: Re: [net-next v5 3/3] net: ethernet: mtk_eth_soc: skip first IRQ if not used
> >
> > On Wed, Jun 18, 2025 at 03:07:14PM +0200, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <frank-w@public-files.de>
> > > 
> > > On SoCs without MTK_SHARED_INT capability (all except mt7621 and
> > > mt7628) platform_get_irq() is called for the first IRQ (eth->irq[0])
> > > but it is never used.
> > > Skip the first IRQ and reduce the IRQ-count to 2.
> > > 
> > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > > ---
> > > v5:
> > > - change commit title and description
> > > v4:
> > > - drop >2 condition as max is already 2 and drop the else continue
> > > - update comment to explain which IRQs are taken in legacy way
> > 
> > Reviewed-by: Simon Horman <horms@kernel.org>
> 
> thank you very much
> 
> i guess RB is still valid with changes requested by Daniel?

Yes, thanks for asking.