All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Snowhill <kode54@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: "Christopher Snowhill" <chris@kode54.net>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Christopher Snowhill" <kode54@gmail.com>
Subject: [RFC PATCH] drm/amdgpu: Enable async flip for cursor planes
Date: Thu, 19 Jun 2025 05:55:05 -0700	[thread overview]
Message-ID: <20250619125507.54384-1-kode54@gmail.com> (raw)

From: Christopher Snowhill <chris@kode54.net>

amdgpu apparently fudges atomic flips if some software is also tweaking
the cursor planes during flips, which results in lovely fallback to non-
atomic flips.

Fixes: 41129e236f14 ("drm/amdgpu: Enable async flip on overlay planes")
Signed-off-by: Christopher Snowhill <chris@kode54.net>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

 Is there some reason why this was decided to be this way? I see it
 hasn't changed much since 2018, until the addition of overlay
 plane checking.

 Re: https://gitlab.freedesktop.org/drm/amd/-/issues/4263

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
index b7c6e8d13435..f0c98d67e1f3 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
@@ -1268,7 +1268,8 @@ static int amdgpu_dm_plane_atomic_async_check(struct drm_plane *plane,
 	struct dm_crtc_state *dm_new_crtc_state;
 
 	if (flip) {
-		if (plane->type != DRM_PLANE_TYPE_OVERLAY)
+		if (plane->type != DRM_PLANE_TYPE_OVERLAY &&
+		    plane->type != DRM_PLANE_TYPE_CURSOR)
 			return -EINVAL;
 	} else if (plane->type != DRM_PLANE_TYPE_CURSOR) {
 		return -EINVAL;
-- 
2.50.0


             reply	other threads:[~2025-06-19 14:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 12:55 Christopher Snowhill [this message]
2025-06-20  9:22 ` [RFC PATCH] drm/amdgpu: Enable async flip for cursor planes Christopher Snowhill
2025-06-20 10:10 ` Christopher Snowhill
2025-06-23 10:46   ` Christopher Snowhill
2025-06-23 11:06     ` Christopher Snowhill
2025-06-23 13:38       ` Christopher Snowhill
2025-06-23 15:33         ` Alex Deucher
2025-08-15 13:17           ` Alex Deucher
2025-08-15 23:21             ` Christopher Snowhill
2025-08-15 16:11         ` Leo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250619125507.54384-1-kode54@gmail.com \
    --to=kode54@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chris@kode54.net \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.