From: Simon Horman <horms@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ip6_tunnel: enable to change proto of fb tunnels
Date: Thu, 19 Jun 2025 14:45:47 +0100 [thread overview]
Message-ID: <20250619134547.GS1699@horms.kernel.org> (raw)
In-Reply-To: <20250617160126.1093435-1-nicolas.dichtel@6wind.com>
On Tue, Jun 17, 2025 at 06:01:25PM +0200, Nicolas Dichtel wrote:
> This is possible via the ioctl API:
> > ip -6 tunnel change ip6tnl0 mode any
>
> Let's align the netlink API:
> > ip link set ip6tnl0 type ip6tnl mode any
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Thanks,
Looking over the code, I agree that this is supported by the ioctl
interface. And, for consistency, I think it makes sense for the netlink
interface to do so too.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-06-19 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 16:01 [PATCH net-next] ip6_tunnel: enable to change proto of fb tunnels Nicolas Dichtel
2025-06-19 13:45 ` Simon Horman [this message]
2025-06-19 22:52 ` Jakub Kicinski
2025-06-20 8:14 ` Nicolas Dichtel
2025-06-21 13:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619134547.GS1699@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.