Re: [PATCH] NFSv4/pNFS: Fix a race to wake on NFS_LAYOUT_DRAIN

[kernel test robot <lkp@intel.com>]

Hi Benjamin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on trondmy-nfs/linux-next]
[also build test WARNING on linus/master v6.16-rc2 next-20250618]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Coddington/NFSv4-pNFS-Fix-a-race-to-wake-on-NFS_LAYOUT_DRAIN/20250619-023749
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link:    https://lore.kernel.org/r/43be0de9ff48ea68dec20d07cb235e164e634588.1750271744.git.bcodding%40redhat.com
patch subject: [PATCH] NFSv4/pNFS: Fix a race to wake on NFS_LAYOUT_DRAIN
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250619/202506192044.sMgMZpkZ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250619/202506192044.sMgMZpkZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506192044.sMgMZpkZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/nfs/pnfs.c: In function 'nfs_layoutget_end':
>> fs/nfs/pnfs.c:2061:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
    2061 |         if (atomic_dec_and_test(&lo->plh_outstanding) &&
         |         ^~
   fs/nfs/pnfs.c:2064:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    2064 |                 wake_up_bit(&lo->plh_flags, NFS_LAYOUT_DRAIN);
         |                 ^~~~~~~~~~~


vim +/if +2061 fs/nfs/pnfs.c

411ae722d10a6d Trond Myklebust     2018-06-23  2058  
411ae722d10a6d Trond Myklebust     2018-06-23  2059  static void nfs_layoutget_end(struct pnfs_layout_hdr *lo)
411ae722d10a6d Trond Myklebust     2018-06-23  2060  {
880265c77ac415 Trond Myklebust     2022-05-31 @2061  	if (atomic_dec_and_test(&lo->plh_outstanding) &&
880265c77ac415 Trond Myklebust     2022-05-31  2062  	    test_and_clear_bit(NFS_LAYOUT_DRAIN, &lo->plh_flags))
b844d0ad43d3ba Benjamin Coddington 2025-06-18  2063  		smp_mb__after_atomic();
880265c77ac415 Trond Myklebust     2022-05-31  2064  		wake_up_bit(&lo->plh_flags, NFS_LAYOUT_DRAIN);
411ae722d10a6d Trond Myklebust     2018-06-23  2065  }
411ae722d10a6d Trond Myklebust     2018-06-23  2066  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki