Re: [PATCH net-next 04/10] eth: benet: migrate to new RXFH callbacks

[Simon Horman <horms@kernel.org>]

On Wed, Jun 18, 2025 at 01:38:17PM -0700, Jakub Kicinski wrote:
> Migrate to new callbacks added by commit 9bb00786fc61 ("net: ethtool:
> add dedicated callbacks for getting and setting rxfh fields").
> 
> The driver has no other RXNFC functionality so the SET callback can
> be now removed.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Simon Horman <horms@kernel.org>

...

> @@ -1132,11 +1139,20 @@ static int be_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,
>  	return 0;
>  }
>  
> -static int be_set_rss_hash_opts(struct be_adapter *adapter,
> -				struct ethtool_rxnfc *cmd)
> +

super nit: there are two consecutive blank lines are here now

> +static int be_set_rxfh_fields(struct net_device *netdev,
> +			      const struct ethtool_rxfh_fields *cmd,
> +			      struct netlink_ext_ack *extack)
>  {
> -	int status;
> +	struct be_adapter *adapter = netdev_priv(netdev);
>  	u32 rss_flags = adapter->rss_info.rss_flags;
> +	int status;
> +
> +	if (!be_multi_rxq(adapter)) {
> +		dev_err(&adapter->pdev->dev,
> +			"ethtool::set_rxfh: RX flow hashing is disabled\n");
> +		return -EINVAL;
> +	}
>  
>  	if (cmd->data != L3_RSS_FLAGS &&
>  	    cmd->data != (L3_RSS_FLAGS | L4_RSS_FLAGS))