From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:8ed0:b0:1be9:327d:8ee3 with SMTP id kh16csp744394njc; Fri, 20 Jun 2025 01:50:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXKlRgZYci7aHRiv8501W7LcMJHOFBxWjLWeb3Tb0DL7c2U9YyWf+2OHBiBvIIbBcCc8Hh8Uv/v/xZ4+g==@linaro.org X-Google-Smtp-Source: AGHT+IE9F+et4yosCwFyB6TNshwQQqgD9B0ruA0+RLn7DVldKx14aHmUIXxf4aOmy/WA7/LAb+yY X-Received: by 2002:a05:6000:4614:b0:3a5:287b:da02 with SMTP id ffacd0b85a97d-3a6d12e5cfcmr1514505f8f.40.1750409429898; Fri, 20 Jun 2025 01:50:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1750409429; cv=none; d=google.com; s=arc-20240605; b=X7XjUqqMnWncSf4upLw5HrjYOUBKlbLDiLqCuyZ0NdcEgzGbOeUmWeSGtI3Hnqabet W53JekIcqODgrsFh/hGLLBHM9LSe/sfpuCEFFD4INO018qpg7i8z5p9/L29w4gAkqNN8 ItM6PNy/bppA74lQ41wZ9OY44SU6GF0dwolLt7+wshhtq17QtwNs8D5KPnlDbK4H69jC W1sD3he0OYLTEqRGzbOSi7AHUx4HV4a5Go4OR/xs/nMpijd6KfmUVqs1sfVG9XHV/+M7 aojE1zaoS/ImU5Ngq+zaQEmcp+GVUlkLGSaiRy4EsLYxH4p2nNiHGuhl3zmt194DaKpY 19cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=N9ZHrJq7I2GIXM+fE0CP51JNdiuP0hffu3uTUKKwuRA=; fh=De5j/+RFiHp5oysg/kfBHcT9O0ASuV5hpNukEk4skqM=; b=inaqXcg82Jt+lI1uNpRjpDqj3n2bJAAgB+8HDnXObHubWF6W2saih7qj1b6aSSU6Tp o7hZjmS6GOx6AI80rWXTOvm+EF9vkMtX0HKcPudepp/TiJXoPDxk74XyNIy44ehd1dSo 5hKJT07q16usr/jBALV/Sx2Gx7iAfy4tsPEXkTCVviseNZ9Qn6Xr1OJ9DgmlSxQOdQWM oR0UaKwBpaY3DesF7BodR2proYomXkS0NLd9lPPT/huVi9KVUmRQfS70OKCL28qU3Rgp zJSvXO67mdBrwMvR9NWEa5YCHhnSS4MoFWPU+zRX6rw2VtmZyvAW/UUahOg/9RqbFWKD lQkg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from frasgout.his.huawei.com (frasgout.his.huawei.com. [185.176.79.56]) by mx.google.com with ESMTPS id ffacd0b85a97d-3a6d12a3580si939335f8f.696.2025.06.20.01.50.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jun 2025 01:50:29 -0700 (PDT) Received-SPF: pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) client-ip=185.176.79.56; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bNrj66xdDz6L6GP; Fri, 20 Jun 2025 16:48:10 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 1D8C41402FE; Fri, 20 Jun 2025 16:50:29 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Jun 2025 10:50:28 +0200 Date: Fri, 20 Jun 2025 09:50:27 +0100 From: Jonathan Cameron To: Eric Auger CC: , , , , , , , , , , , Subject: Re: [PATCH v3 06/29] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation Message-ID: <20250620095027.00005cfc@huawei.com> In-Reply-To: <20250616094903.885753-7-eric.auger@redhat.com> References: <20250616094903.885753-1-eric.auger@redhat.com> <20250616094903.885753-7-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) X-TUID: Ex0C05AAuxqg On Mon, 16 Jun 2025 11:46:35 +0200 Eric Auger wrote: > acpi_dsdt_add_pci_osc() name is confusing as it gives the impression > it appends the _OSC method but in fact it also appends the _DSM method > for the host bridge. Let's split the function into two separate ones > and let them return the method Aml pointer instead. This matches the > way it is done on x86 (build_q35_osc_method). In a subsequent patch > we will replace the gpex method by the q35 implementation that will > become shared between ARM and x86. > > acpi_dsdt_add_host_bridge_methods is a new top helper that generates > both the _OSC and _DSM methods. > > We take the opportunity to move SUPP and CTRL in the _osc method > that use them. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 792C5C71155 for ; Fri, 20 Jun 2025 08:50:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSXSH-0002ft-Sq; Fri, 20 Jun 2025 04:50:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSXSF-0002dJ-Hi; Fri, 20 Jun 2025 04:50:35 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSXSD-0002c2-MO; Fri, 20 Jun 2025 04:50:35 -0400 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bNrj66xdDz6L6GP; Fri, 20 Jun 2025 16:48:10 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 1D8C41402FE; Fri, 20 Jun 2025 16:50:29 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Jun 2025 10:50:28 +0200 Date: Fri, 20 Jun 2025 09:50:27 +0100 To: Eric Auger CC: , , , , , , , , , , , Subject: Re: [PATCH v3 06/29] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation Message-ID: <20250620095027.00005cfc@huawei.com> In-Reply-To: <20250616094903.885753-7-eric.auger@redhat.com> References: <20250616094903.885753-1-eric.auger@redhat.com> <20250616094903.885753-7-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 16 Jun 2025 11:46:35 +0200 Eric Auger wrote: > acpi_dsdt_add_pci_osc() name is confusing as it gives the impression > it appends the _OSC method but in fact it also appends the _DSM method > for the host bridge. Let's split the function into two separate ones > and let them return the method Aml pointer instead. This matches the > way it is done on x86 (build_q35_osc_method). In a subsequent patch > we will replace the gpex method by the q35 implementation that will > become shared between ARM and x86. > > acpi_dsdt_add_host_bridge_methods is a new top helper that generates > both the _OSC and _DSM methods. > > We take the opportunity to move SUPP and CTRL in the _osc method > that use them. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron