From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:8ed0:b0:1be9:327d:8ee3 with SMTP id kh16csp745883njc; Fri, 20 Jun 2025 01:54:50 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWe3BKBkx4fcleV8ZAgXbBy9fOukKN2UFHhiKnm1aqe2AaNiVxWu4RHZtIB9QJDQ+zMFSMCz8ERK8EPHg==@linaro.org X-Google-Smtp-Source: AGHT+IGySq6w6R8d6TPhredY5emRaIwaGJGf0hpt/ZzoKlk+pENV3VHYRd1xjMvJNYzRJws39UA/ X-Received: by 2002:a05:600c:b8a:b0:450:d4a6:799e with SMTP id 5b1f17b1804b1-453658bac1fmr13626755e9.20.1750409690135; Fri, 20 Jun 2025 01:54:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1750409690; cv=none; d=google.com; s=arc-20240605; b=Er44RE+/RVldpI6DszAHCvEp/oqjues5TxnpZ4sYwat1Y9MweXUJYQmgwXFf5fMyc4 IHfWYkZLCfpP0me6aGS0jvodUcemRVBUvdUXpCsfqUHK6GSsFLfS7YUdcBtqfbquGpAK FeFpKhwggNgvJ1qddyWmdrtIc663vSWSS0ZFsbK7zHK8JNgr2zgszoUH3eKSwMP4kQVC 1m3frBk07olJAlo0myIK2/Cn7okFoCG1IF9Leal9P2zSIT+hK3rQfPhL2lN5aCm/9Mfb cNTk1qy1kjt083vjz8ZwlTOnXKnPK+HH0463wnNF8DAVxcmfWXbwj2fNShWgyI5mCvf1 wCaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=+mJNBU7QNBLdvsz4aUFBLf1cox6A/ndPGjjAnlc4zvo=; fh=De5j/+RFiHp5oysg/kfBHcT9O0ASuV5hpNukEk4skqM=; b=EqiWvdodCUJjaetCtVsWRSIM+Qu9cC/L92n1GWtEDbDa/zX1HFjx78JKrkCovFuxIP d9SDZRrgXxl9NOP59GBEVolaypm7rDwNpV+0NqZXt6vgBPjK3xGsceisEpM+kMwoYu3l Eu2Gg9fET+WOw6hjpp7Wd2l5nol81XgYBJmw65bCU49ulEMkmWgdCUl0Dt9mULXEUw+7 3be7UHHbOkR/+fi6fAiUQQ9k2jUwVxbmSfLVIwnysKpU28+Vc8CNMXyOa7tuDqxfVyR0 lwjcHb7tZGu2gXIBmrhB/3MfPT3bxI6wgj1OmMpU9pcrxNS2iWskBnr6e04tHcN0e/hZ vBAQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from frasgout.his.huawei.com (frasgout.his.huawei.com. [185.176.79.56]) by mx.google.com with ESMTPS id ffacd0b85a97d-3a6d117ef1asi1044942f8f.234.2025.06.20.01.54.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jun 2025 01:54:50 -0700 (PDT) Received-SPF: pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) client-ip=185.176.79.56; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bNrr326Khz6M60P; Fri, 20 Jun 2025 16:54:11 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 2DC8314027A; Fri, 20 Jun 2025 16:54:49 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Jun 2025 10:54:48 +0200 Date: Fri, 20 Jun 2025 09:54:47 +0100 From: Jonathan Cameron To: Eric Auger CC: , , , , , , , , , , , Subject: Re: [PATCH v3 08/29] hw/i386/acpi-build: Turn build_q35_osc_method into a generic method Message-ID: <20250620095447.000062b8@huawei.com> In-Reply-To: <20250616094903.885753-9-eric.auger@redhat.com> References: <20250616094903.885753-1-eric.auger@redhat.com> <20250616094903.885753-9-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) X-TUID: qtGCUZ1SJgB2 On Mon, 16 Jun 2025 11:46:37 +0200 Eric Auger wrote: > GPEX acpi_dsdt_add_pci_osc() does basically the same as > build_q35_osc_method(). > > Rename build_q35_osc_method() into build_pci_host_bridge_osc_method() > and move it into hw/acpi/pci.c. In a subsequent patch we will > use this later in place of acpi_dsdt_add_pci_osc(). > > Signed-off-by: Eric Auger New location makes sense. Reviewed-by: Jonathan Cameron From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89365C7115B for ; Fri, 20 Jun 2025 08:55:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSXWS-000526-N8; Fri, 20 Jun 2025 04:54:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSXWP-00051U-93; Fri, 20 Jun 2025 04:54:53 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSXWN-0003BE-7h; Fri, 20 Jun 2025 04:54:53 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bNrr326Khz6M60P; Fri, 20 Jun 2025 16:54:11 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 2DC8314027A; Fri, 20 Jun 2025 16:54:49 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Jun 2025 10:54:48 +0200 Date: Fri, 20 Jun 2025 09:54:47 +0100 To: Eric Auger CC: , , , , , , , , , , , Subject: Re: [PATCH v3 08/29] hw/i386/acpi-build: Turn build_q35_osc_method into a generic method Message-ID: <20250620095447.000062b8@huawei.com> In-Reply-To: <20250616094903.885753-9-eric.auger@redhat.com> References: <20250616094903.885753-1-eric.auger@redhat.com> <20250616094903.885753-9-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 16 Jun 2025 11:46:37 +0200 Eric Auger wrote: > GPEX acpi_dsdt_add_pci_osc() does basically the same as > build_q35_osc_method(). > > Rename build_q35_osc_method() into build_pci_host_bridge_osc_method() > and move it into hw/acpi/pci.c. In a subsequent patch we will > use this later in place of acpi_dsdt_add_pci_osc(). > > Signed-off-by: Eric Auger New location makes sense. Reviewed-by: Jonathan Cameron