From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B1A4C71157 for ; Sat, 21 Jun 2025 12:13:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DD34180768; Sat, 21 Jun 2025 12:13:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 9IhG4EE68dN2; Sat, 21 Jun 2025 12:13:52 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 68B2C8077E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1750508032; bh=HfEnZjfoEyj4xag925X7xxtib6QNWtCv9SjFZFY7CZg=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wgL0kpGhlggVndQJp0QtSEX4lUSC/s5Fj2WI5rPSuLnEoHX/2wK/HnM4BN9M6j6a/ 6is53oTzQTZxysuGtviynzOy8zcJXA4GSi53Wom6y6lChjZ77iV6Id4EiSuwtFGmM3 QWtlVyzNYwbRjD1YWOwSJ2iLTuQrn8T8sS2v/BpQ0gSinDfOsBKJM8uJ96q6ilOAC5 zJUFE7HWaezpuPbY7FQwpP0dvW+xK5T1vJzHY84HENMxtanW4KRMo+H6W4gRfkAA9t mfTMEcLQYWkxBTe8BKVrFo3LhYpHxb6qdvEUsR/Lwt1jmFaWNt0aSikcz9WccCIdHV ZhaOG8PBv5Rcg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 68B2C8077E; Sat, 21 Jun 2025 12:13:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 884B0C8 for ; Sat, 21 Jun 2025 12:13:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6F07C60724 for ; Sat, 21 Jun 2025 12:13:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id VOqYcVYC0R5W for ; Sat, 21 Jun 2025 12:13:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org E7EC66070B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E7EC66070B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id E7EC66070B for ; Sat, 21 Jun 2025 12:13:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 50BD75C20F0; Sat, 21 Jun 2025 12:11:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C047C4CEE7; Sat, 21 Jun 2025 12:13:48 +0000 (UTC) Date: Sat, 21 Jun 2025 13:13:46 +0100 From: Simon Horman To: Ahmed Zaki Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Madhu Chittim Message-ID: <20250621121346.GD71935@horms.kernel.org> References: <20250620171548.959863-1-ahmed.zaki@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250620171548.959863-1-ahmed.zaki@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750508029; bh=RAruDr6SBXBNz/lR+POgRgxABSTjO6lM1PMHGV3mfgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MGiMFS9Khtj/2vqrD3h9oMuGxs+4QoXV9frEHAr1Qhn0uu0N3hUUn6t1hoA+h4Jm4 RufIfRY8I0BfWvK41Oun1LqBzi7/ahPLcfIqIW37rWGNVD/g5pVqrOiNalGOSShLdd o8+4Hp2wzkDmTLIi9PsWAqH+Sn0iTQ6aFJg9lQVabx4Cz+2Ofccld9kEYr2n+NVhvl +kchc8O16Y33Nm4FeVqU1BqxTRT6nbQNU7Cr4Si9XltU9n+P1hyXJ64uDiscB5Nhap RQVICFQiEl3wtB6OQPowJ8WCNxyakS2Xy6BVjnzQ4+h6WAgmXSZY9dfAjTPzhrpowM iwFpdXBIzfZ3g== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=MGiMFS9K Subject: Re: [Intel-wired-lan] [PATCH iwl-next] idpf: preserve coalescing settings across resets X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Jun 20, 2025 at 11:15:48AM -0600, Ahmed Zaki wrote: > The IRQ coalescing config currently reside only inside struct > idpf_q_vector. However, all idpf_q_vector structs are de-allocated and > re-allocated during resets. This leads to user-set coalesce configuration > to be lost. > > Add new fields to struct idpf_vport_user_config_data to save the user > settings and re-apply them after reset. > > Reviewed-by: Madhu Chittim > Signed-off-by: Ahmed Zaki Hi Ahmed, I am wondering if this patch also preserves coalescing settings in the case where. 1. User sets coalescence for n queues 2. The number of queues is reduced, say to m (where m < n) 3. The user then increases the number of queues, say back to n It seems to me that in this scenario it's reasonable to preserve the settings for queues 0 to m, bit not queues m + 1 to n. But perhaps this point is orthogonal to this change. I am unsure. ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A3091DDE9 for ; Sat, 21 Jun 2025 12:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750508030; cv=none; b=uPX/CfHmy8mY0eOgp/HZxC7jHupcoxKHkpFeKcEI8lm18Yk8QY/ur+HS6jqAOj6npeqdOPkiZeqne8zuNuySH94iPo3GKT5GH7eQg0NeytCQPhRfkj7CGXMR38pEjR/eheYhJfBb9wCyy8IW7VefAUaJMZ+g3zKDasOJkju9ics= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750508030; c=relaxed/simple; bh=RAruDr6SBXBNz/lR+POgRgxABSTjO6lM1PMHGV3mfgQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XtiQAOwIZo3pBrxTs0Hnc0sTu8xn+M4Bg108/Xo8E6dhKbVfEnL31NF/DeG54SomJtqOrZ+iBxWdW6MU+M73GQ5YWigJuSJmlOLVNrZL1vcubRekWagddTPQA92nO6F/RgMNi22fNYS+rSDCZKRyZjHHSSgJcHVle2AxreROQYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MGiMFS9K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MGiMFS9K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C047C4CEE7; Sat, 21 Jun 2025 12:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750508029; bh=RAruDr6SBXBNz/lR+POgRgxABSTjO6lM1PMHGV3mfgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MGiMFS9Khtj/2vqrD3h9oMuGxs+4QoXV9frEHAr1Qhn0uu0N3hUUn6t1hoA+h4Jm4 RufIfRY8I0BfWvK41Oun1LqBzi7/ahPLcfIqIW37rWGNVD/g5pVqrOiNalGOSShLdd o8+4Hp2wzkDmTLIi9PsWAqH+Sn0iTQ6aFJg9lQVabx4Cz+2Ofccld9kEYr2n+NVhvl +kchc8O16Y33Nm4FeVqU1BqxTRT6nbQNU7Cr4Si9XltU9n+P1hyXJ64uDiscB5Nhap RQVICFQiEl3wtB6OQPowJ8WCNxyakS2Xy6BVjnzQ4+h6WAgmXSZY9dfAjTPzhrpowM iwFpdXBIzfZ3g== Date: Sat, 21 Jun 2025 13:13:46 +0100 From: Simon Horman To: Ahmed Zaki Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Madhu Chittim Subject: Re: [PATCH iwl-next] idpf: preserve coalescing settings across resets Message-ID: <20250621121346.GD71935@horms.kernel.org> References: <20250620171548.959863-1-ahmed.zaki@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250620171548.959863-1-ahmed.zaki@intel.com> On Fri, Jun 20, 2025 at 11:15:48AM -0600, Ahmed Zaki wrote: > The IRQ coalescing config currently reside only inside struct > idpf_q_vector. However, all idpf_q_vector structs are de-allocated and > re-allocated during resets. This leads to user-set coalesce configuration > to be lost. > > Add new fields to struct idpf_vport_user_config_data to save the user > settings and re-apply them after reset. > > Reviewed-by: Madhu Chittim > Signed-off-by: Ahmed Zaki Hi Ahmed, I am wondering if this patch also preserves coalescing settings in the case where. 1. User sets coalescence for n queues 2. The number of queues is reduced, say to m (where m < n) 3. The user then increases the number of queues, say back to n It seems to me that in this scenario it's reasonable to preserve the settings for queues 0 to m, bit not queues m + 1 to n. But perhaps this point is orthogonal to this change. I am unsure. ...