All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Mohammad Jahangirzad <a.jahangirzad@gmail.com>
Cc: hubcap@omnibond.com, martin@omnibond.com,
	devel@lists.orangefs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/orangefs: use snprintf() instead of sprintf()
Date: Sun, 22 Jun 2025 19:48:15 +0100	[thread overview]
Message-ID: <20250622184815.GW1880847@ZenIV> (raw)
In-Reply-To: <CADf5TKvyKvaP3eZUR81ND6JQUfVqUEroCrXp=joZ8GHdu2EBbA@mail.gmail.com>

On Sun, Jun 22, 2025 at 10:09:58PM +0330, Amir Mohammad Jahangirzad wrote:

> > Replace sprintf() with snprintf() for copying the debug string
> > into a temporary buffer, using ORANGEFS_MAX_DEBUG_STRING_LEN as
> > the maximum size to ensure safe formatting and prevent memory
> > corruption in edge cases.

Out of curiosity - have you actually looked at the format used there?

  reply	other threads:[~2025-06-22 18:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-08 16:35 [PATCH] fs/orangefs: use snprintf() instead of sprintf() Amir Mohammad Jahangirzad
2025-06-22 18:39 ` Amir Mohammad Jahangirzad
2025-06-22 18:48   ` Al Viro [this message]
2025-06-22 20:09     ` Amir Mohammad Jahangirzad
2025-06-23 17:02       ` Mike Marshall
2025-06-30 17:18         ` Mike Marshall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250622184815.GW1880847@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=a.jahangirzad@gmail.com \
    --cc=devel@lists.orangefs.org \
    --cc=hubcap@omnibond.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@omnibond.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.