From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:7301:19ab:b0:175:694b:cb76 with SMTP id mc43csp2485788dyb; Mon, 23 Jun 2025 04:36:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUbN7SrMO0phsjhUJGohw2fIBNIKgzMzyvSG62ENjT2U7ucWoi7B3Xr1KjuEzCfWzGHN2SK8wx2mcCBjw==@linaro.org X-Google-Smtp-Source: AGHT+IGXnIGSxGehowgTkPRLYmYCfkzZt+ZSyZP0aS7BBKximmsd68eoCUMfviy5xQbQ8hnA/MJG X-Received: by 2002:a05:620a:a810:b0:7d4:451:b8cb with SMTP id af79cd13be357-7d40451bcbdmr1032190385a.4.1750678595173; Mon, 23 Jun 2025 04:36:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1750678595; cv=none; d=google.com; s=arc-20240605; b=fOt67CWdOnJZYivt4aOhGHlCNXs5ZhKEpllddyHvSlRTyVfiX2ex0c8cI7lUB5bCe1 ruBH68iz/BBa9iX11dzuYoad73K/8+4EK7O8LYbLGtX/q2qDA1ZJvozejklaAlERJeOJ g6/HeEbgEi6I4iPbCKB9v+Pk9VphhmpDsbA/L97wNpGXnLaBVZLO4SQDnJmZv+mt7TZU jSQmbbb3E+IIahxG5x/LLpf0nLeb9sdVanZP9Q7kXMP8rWyT6OMK5LXSCd5JdQrlBg6o xapsGTTOC/IofN+Pk4bTs85DW5dltQBF/ZJAcdwvuYwHkKwfdsXvTILpDogFBvY55qYf dluA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:from:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:date; bh=sERH6wYFQAuW+FgvELxg1b2EaeSnquOThHPg/hT8VN8=; fh=nDSQDZidiGeJ2daiUwC1/Yd3QXQYWxkzypgrkUaKy1k=; b=ga7HDZ4mLL3vWrYouSoBqrvswnU99fkZszeRM4bsHTZrNB9YXwdpxoDwIk+b0tQRJR Idqv/25YNOHJ6ireZICTrnLsHXr3z5eRAU380SR+2446iRPkR6s64IevjP+j9Z6PouhP tPJHa56x72TeBUANbKrj2+XpHSPpfBTq2gW+6ctd/sk4GtS5+wjcCiWtV1uzqw9juVFg wMNiJOl2a2N9JHD4F5sAPIo4Aqdd/FlTijhLbyKC7uZCP3/jeVLlT7qzLzxjyezF9iYR pYZfCutOc4n9t5nyv0QSiGIyOsBKWaCC13kPg/u9UVbPvakZ9a0dbH10588gE3S+yBxl BEjA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7d3f9a22f5fsi744703585a.614.2025.06.23.04.36.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jun 2025 04:36:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uTfT0-0002FS-Of; Mon, 23 Jun 2025 07:36:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTfSs-0002BK-UJ; Mon, 23 Jun 2025 07:35:56 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTfSn-00034t-E9; Mon, 23 Jun 2025 07:35:54 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bQmDC6KzWz6HJxW; Mon, 23 Jun 2025 19:33:15 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id C71BF1402E9; Mon, 23 Jun 2025 19:35:42 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 23 Jun 2025 13:35:41 +0200 Date: Mon, 23 Jun 2025 12:35:39 +0100 To: Shameer Kolothum , CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 05/11] hw/arm/virt: Add an SMMU_IO_LEN macro Message-ID: <20250623123525.0000607b@huawei.com> In-Reply-To: <20250623094230.76084-6-shameerali.kolothum.thodi@huawei.com> References: <20250623094230.76084-1-shameerali.kolothum.thodi@huawei.com> <20250623094230.76084-6-shameerali.kolothum.thodi@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: fodW3lqPq4Gs On Mon, 23 Jun 2025 10:42:24 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > This is useful as the subsequent support for new SMMUv3 dev will also > use the same. > > Signed-off-by: Nicolin Chen > Reviewed-by: Donald Dutile > Reviewed-by: Eric Auger > Tested-by: Nathan Chen > Signed-off-by: Shameer Kolothum Reviewed-by: Jonathan Cameron > --- > hw/arm/virt.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 71b923f786..ae30320c38 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -146,6 +146,9 @@ static void arm_virt_compat_set(MachineClass *mc) > #define LEGACY_RAMLIMIT_GB 255 > #define LEGACY_RAMLIMIT_BYTES (LEGACY_RAMLIMIT_GB * GiB) > > +/* MMIO region size for SMMUv3 */ > +#define SMMU_IO_LEN 0x20000 > + > /* Addresses and sizes of our components. > * 0..128MB is space for a flash device so we can run bootrom code such as UEFI. > * 128MB..256MB is used for miscellaneous device I/O. > @@ -177,7 +180,7 @@ static const MemMapEntry base_memmap[] = { > [VIRT_FW_CFG] = { 0x09020000, 0x00000018 }, > [VIRT_GPIO] = { 0x09030000, 0x00001000 }, > [VIRT_UART1] = { 0x09040000, 0x00001000 }, > - [VIRT_SMMU] = { 0x09050000, 0x00020000 }, > + [VIRT_SMMU] = { 0x09050000, SMMU_IO_LEN }, > [VIRT_PCDIMM_ACPI] = { 0x09070000, MEMORY_HOTPLUG_IO_LEN }, > [VIRT_ACPI_GED] = { 0x09080000, ACPI_GED_EVT_SEL_LEN }, > [VIRT_NVDIMM_ACPI] = { 0x09090000, NVDIMM_ACPI_IO_LEN},