All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alex.kanavin@gmail.com>
To: docs@lists.yoctoproject.org
Cc: Alexander Kanavin <alex@linutronix.de>
Subject: [PATCH 6/6] migration-guides/migration-5.1.rst: correct S/UNPACKDIR patterns for file-only recipes
Date: Mon, 23 Jun 2025 14:42:57 +0200	[thread overview]
Message-ID: <20250623124257.1544615-6-alex.kanavin@gmail.com> (raw)
In-Reply-To: <20250623124257.1544615-1-alex.kanavin@gmail.com>

From: Alexander Kanavin <alex@linutronix.de>

It is not necessary to set both; just setting S to UNPACKDIR is enough.

This has already been done across oe-core master, and correct advice
should be given for those who need to adjust recipes during migration.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 documentation/migration-guides/migration-5.1.rst | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/documentation/migration-guides/migration-5.1.rst b/documentation/migration-guides/migration-5.1.rst
index c9bb38699b4..94b527bdcb3 100644
--- a/documentation/migration-guides/migration-5.1.rst
+++ b/documentation/migration-guides/migration-5.1.rst
@@ -20,8 +20,7 @@ S = ${WORKDIR} no longer supported
 If a recipe has :term:`S` set to be :term:`WORKDIR`, this is no longer
 supported, and an error will be issued. The recipe should be changed to::
 
-    S = "${WORKDIR}/sources"
-    UNPACKDIR = "${S}"
+    S = "${UNPACKDIR}"
 
 Any :term:`WORKDIR` references where files from :term:`SRC_URI` are referenced
 should be changed to :term:`S`. These are commonly in :ref:`ref-tasks-compile`,
@@ -62,8 +61,7 @@ require to add an :term:`S` definition to a recipe that only uses
 ``file://`` :term:`SRC_URI` entries. To be consistent, the following pattern is
 recommended::
 
-    S = "${WORKDIR}/sources"
-    UNPACKDIR = "${S}"
+    S = "${UNPACKDIR}"
 
 Building C files from :term:`UNPACKDIR` without setting :term:`S` to point at
 it does not work as the debug prefix mapping doesn't handle that.
-- 
2.39.5



  parent reply	other threads:[~2025-06-23 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 12:42 [PATCH 1/6] overview-manual: correct value of UNPACKDIR and put S under it Alexander Kanavin
2025-06-23 12:42 ` [PATCH 2/6] ref-manual: drop a sentence about a 'legacy way' to specify UNPACKDIR Alexander Kanavin
2025-06-23 12:42 ` [PATCH 3/6] dev-manual: replace WORKDIR with UNPACKDIR where appropriate Alexander Kanavin
2025-06-23 12:42 ` [PATCH 4/6] overview-manual: correct the bitbake tasks map section and diagram to account for sources in UNPACKDIR Alexander Kanavin
2025-06-23 12:42 ` [PATCH 5/6] ref-manual: correct references to WORKDIR to account for recent do_unpack changes Alexander Kanavin
2025-06-23 12:42 ` Alexander Kanavin [this message]
2025-06-24  7:43   ` [docs] [PATCH 6/6] migration-guides/migration-5.1.rst: correct S/UNPACKDIR patterns for file-only recipes Antonin Godard
2025-06-24  9:13     ` Alexander Kanavin
2025-06-24  9:38       ` Antonin Godard
2025-07-01  8:37 ` [PATCH 1/6] overview-manual: correct value of UNPACKDIR and put S under it Antonin Godard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250623124257.1544615-6-alex.kanavin@gmail.com \
    --to=alex.kanavin@gmail.com \
    --cc=alex@linutronix.de \
    --cc=docs@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.