From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D56A1EEA3C; Mon, 23 Jun 2025 21:29:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714155; cv=none; b=Kvpd2ohGUcJP4hijfCyYsVrymSyaDvOoMo04XBw3iKKJb+s/vPwSMI1J8KeTSow+xfQbsLzvD0ccEcAeQfKJUHu/eG29gr75ZLYYfGglA3EnjykRoRW9kl7kSf0tUjYtEbjC1mzYhob69vKPbSEkVWf2yks5AS76OBd4dm1e3T0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714155; c=relaxed/simple; bh=+6oM5PcJyuL8OPqQ4Dwn4fvvE0BLYuTyAusq4HxUfo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QWnnjPUPk1NE5lFiViKL97xhFfvOIvlOHjljWXIkjeWCkBr6qk2GfQouNI4CAxGntpy3B4c+rONyJuXwMLhU09vdlztTcxyKxGnG17JbFT++DIHcbX4P730CmnwwH/LVviqizXWpwSOs4MUATY4W9TZC8COF19WvxdmUCRqrBVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cEVzN6rr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cEVzN6rr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB661C4CEEA; Mon, 23 Jun 2025 21:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750714155; bh=+6oM5PcJyuL8OPqQ4Dwn4fvvE0BLYuTyAusq4HxUfo4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cEVzN6rrZcXnB9UpaxJC8A7FJ+3FQ0xjgFWM5n4PfM76IehkQv48KcOtuNGvkrh+t DF/jf0WknXerLcW9LNT34H02F3frky0lP8Pnr61YJo5IHQfaWv1q4xfDpZChEo7ZQ5 1Uaw4NZRuS2qXiYdg4QLzVPrWOaGMr4+QGlG5mRE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bjorn Helgaas , Lukas Wunner , Dave Jiang Subject: [PATCH 5.10 209/355] PCI: Fix lock symmetry in pci_slot_unlock() Date: Mon, 23 Jun 2025 15:06:50 +0200 Message-ID: <20250623130633.029351398@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilpo Järvinen commit f3efb9569b4a21354ef2caf7ab0608a3e14cc6e4 upstream. The commit a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()") made the lock function to call depend on dev->subordinate but left pci_slot_unlock() unmodified creating locking asymmetry compared with pci_slot_lock(). Because of the asymmetric lock handling, the same bridge device is unlocked twice. First pci_bus_unlock() unlocks bus->self and then pci_slot_unlock() will unconditionally unlock the same bridge device. Move pci_dev_unlock() inside an else branch to match the logic in pci_slot_lock(). Fixes: a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()") Signed-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas Reviewed-by: Lukas Wunner Reviewed-by: Dave Jiang Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20250505115412.37628-1-ilpo.jarvinen@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5356,7 +5356,8 @@ static void pci_slot_unlock(struct pci_s continue; if (dev->subordinate) pci_bus_unlock(dev->subordinate); - pci_dev_unlock(dev); + else + pci_dev_unlock(dev); } }