From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0FA81F5820; Mon, 23 Jun 2025 21:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715082; cv=none; b=KUoUfyAAz9cG68/pWj723OLT8sbvpW93Ab4be9mVwbdUp1rOtixPqsR/lWfEmDlU+drmnaH3R3Le624yNe3x/l8yTVI87SzYmqhgQmzjEQhCYt80r2fzDAfqIOa4W3NBx2l2+es9/ZL5VwNmoH87074tFr3OD1HM7lrSEcRiFoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715082; c=relaxed/simple; bh=k7qRBrtYsVuH956lfbYjV36lqpMDWb9eQUMQYSYwf60=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dn89EI+El5q28RKwBI62rIvIf8imf6wp0MCz94NOzOE3QhQ+ecjNzO+vnNZ3feCDCnos2BgtTJmroYvX+z1GSuSSLQ7HrYSyX+lFvMMWM9QNhOJOrhyq/c+5oYYR9fvgyDgOtZuLgVXxZA1SlUFytWVVNfIBa3aLvl+cNChjE6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mOtTb5Zb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mOtTb5Zb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38ADAC4CEEA; Mon, 23 Jun 2025 21:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750715082; bh=k7qRBrtYsVuH956lfbYjV36lqpMDWb9eQUMQYSYwf60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mOtTb5Zb+K8dLekNG+ZeNeD/fDdW9BQ1myN2754qfnUjhMeIXS8L+Y2L5uycxVJMz 9ixNEfvnbY10g5dM36j1/osod8M9mXuEesouctb/evqHEvGs/OKXQ0rDSuq/hORKhn 4czSNn1NqvorqTKxncVCz/F9uJJkhPgSRg7bB/uk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alok Tiwari , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 251/355] emulex/benet: correct command version selection in be_cmd_get_stats() Date: Mon, 23 Jun 2025 15:07:32 +0200 Message-ID: <20250623130634.297471210@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alok Tiwari [ Upstream commit edb888d29748cee674006a52e544925dacc7728e ] Logic here always sets hdr->version to 2 if it is not a BE3 or Lancer chip, even if it is BE2. Use 'else if' to prevent multiple assignments, setting version 0 for BE2, version 1 for BE3 and Lancer, and version 2 for others. Fixes potential incorrect version setting when BE2_chip and BE3_chip/lancer_chip checks could both be true. Signed-off-by: Alok Tiwari Link: https://patch.msgid.link/20250519141731.691136-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c index 9812a9a5d033b..d9bceb26f4e5b 100644 --- a/drivers/net/ethernet/emulex/benet/be_cmds.c +++ b/drivers/net/ethernet/emulex/benet/be_cmds.c @@ -1608,7 +1608,7 @@ int be_cmd_get_stats(struct be_adapter *adapter, struct be_dma_mem *nonemb_cmd) /* version 1 of the cmd is not supported only by BE2 */ if (BE2_chip(adapter)) hdr->version = 0; - if (BE3_chip(adapter) || lancer_chip(adapter)) + else if (BE3_chip(adapter) || lancer_chip(adapter)) hdr->version = 1; else hdr->version = 2; -- 2.39.5