All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,zhanjie9@hisilicon.com,will@kernel.org,viresh.kumar@linaro.org,tglx@linutronix.de,sumit.garg@linaro.org,song@kernel.org,rafael@kernel.org,prime.zeng@hisilicon.com,lecopzer.chen@mediatek.com,kernelfans@gmail.com,Jonathan.Cameron@huawei.com,dianders@chromium.org,catalin.marinas@arm.com,yangyicong@hisilicon.com,akpm@linux-foundation.org
Subject: + arm64-watchdog_hld-add-a-cpufreq-notifier-for-update-watchdog-thresh.patch added to mm-nonmm-unstable branch
Date: Mon, 23 Jun 2025 16:30:54 -0700	[thread overview]
Message-ID: <20250623233054.D3B95C4CEED@smtp.kernel.org> (raw)


The patch titled
     Subject: arm64/watchdog_hld: add a cpufreq notifier for update watchdog thresh
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     arm64-watchdog_hld-add-a-cpufreq-notifier-for-update-watchdog-thresh.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/arm64-watchdog_hld-add-a-cpufreq-notifier-for-update-watchdog-thresh.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Yicong Yang <yangyicong@hisilicon.com>
Subject: arm64/watchdog_hld: add a cpufreq notifier for update watchdog thresh
Date: Thu, 19 Jun 2025 19:48:05 +0800

arm64 depends on the cpufreq driver to gain the maximum cpu frequency to
convert the watchdog_thresh to perf event period.  cpufreq drivers like
cppc_cpufreq will be initialized lately after the initializing of the hard
lockup detector so just use a safe cpufreq which will be inaccurency.  Use
a cpufreq notifier to adjust the event's period to a more accurate one.

Link: https://lkml.kernel.org/r/20250619114805.16968-3-yangyicong@huawei.com
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Doug Anderson <dianders@chromium.org>
Cc: Jie Zhan <zhanjie9@hisilicon.com>
Cc: Joanthan Cameron <Jonathan.Cameron@huawei.com>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: Liu Pingfan <kernelfans@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Song Liu <song@kernel.org>
Cc: Sumit Garg <sumit.garg@linaro.org>
Cc: Thomas Gleinxer <tglx@linutronix.de>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Will Deacon <will@kernel.org>
Cc: Zeng Tao <prime.zeng@hisilicon.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/arm64/kernel/watchdog_hld.c |   58 +++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

--- a/arch/arm64/kernel/watchdog_hld.c~arm64-watchdog_hld-add-a-cpufreq-notifier-for-update-watchdog-thresh
+++ a/arch/arm64/kernel/watchdog_hld.c
@@ -34,3 +34,61 @@ bool __init arch_perf_nmi_is_available(v
 	 */
 	return arm_pmu_irq_is_nmi();
 }
+
+static int watchdog_perf_update_period(void *data)
+{
+	int cpu = raw_smp_processor_id();
+	u64 max_cpu_freq, new_period;
+
+	max_cpu_freq = cpufreq_get_hw_max_freq(cpu) * 1000UL;
+	if (!max_cpu_freq)
+		return 0;
+
+	new_period = watchdog_thresh * max_cpu_freq;
+	hardlockup_detector_perf_adjust_period(cpu, new_period);
+
+	return 0;
+}
+
+static int watchdog_freq_notifier_callback(struct notifier_block *nb,
+					   unsigned long val, void *data)
+{
+	struct cpufreq_policy *policy = data;
+	int cpu;
+
+	if (val != CPUFREQ_CREATE_POLICY)
+		return NOTIFY_DONE;
+
+	/*
+	 * Let each online CPU related to the policy update the period by their
+	 * own. This will serialize with the framework on start/stop the lockup
+	 * detector (softlockup_{start,stop}_all) and avoid potential race
+	 * condition. Otherwise we may have below theoretical race condition:
+	 * (core 0/1 share the same policy)
+	 * [core 0]                      [core 1]
+	 *                               hardlockup_detector_event_create()
+	 *                                 hw_nmi_get_sample_period()
+	 * (cpufreq registered, notifier callback invoked)
+	 * watchdog_freq_notifier_callback()
+	 *   watchdog_perf_update_period()
+	 *   (since core 1's event's not yet created,
+	 *    the period is not set)
+	 *                                 perf_event_create_kernel_counter()
+	 *                                 (event's period is SAFE_MAX_CPU_FREQ)
+	 */
+	for_each_cpu(cpu, policy->cpus)
+		smp_call_on_cpu(cpu, watchdog_perf_update_period, NULL, false);
+
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block watchdog_freq_notifier = {
+	.notifier_call = watchdog_freq_notifier_callback,
+};
+
+static int __init init_watchdog_freq_notifier(void)
+{
+	return cpufreq_register_notifier(&watchdog_freq_notifier,
+					 CPUFREQ_POLICY_NOTIFIER);
+}
+core_initcall(init_watchdog_freq_notifier);
_

Patches currently in -mm which might be from yangyicong@hisilicon.com are

watchdog-perf-provide-function-for-adjusting-the-event-period.patch
arm64-watchdog_hld-add-a-cpufreq-notifier-for-update-watchdog-thresh.patch


                 reply	other threads:[~2025-06-23 23:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250623233054.D3B95C4CEED@smtp.kernel.org \
    --to=akpm@linux-foundation.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=dianders@chromium.org \
    --cc=kernelfans@gmail.com \
    --cc=lecopzer.chen@mediatek.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=rafael@kernel.org \
    --cc=song@kernel.org \
    --cc=sumit.garg@linaro.org \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    --cc=yangyicong@hisilicon.com \
    --cc=zhanjie9@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.