From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v3 02/10] mei: late_bind: add late binding component driver
Date: Tue, 24 Jun 2025 11:14:31 +0800 [thread overview]
Message-ID: <202506241103.XiG3WA7g-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250618190007.2932322-3-badal.nilawar@intel.com>
References: <20250618190007.2932322-3-badal.nilawar@intel.com>
TO: Badal Nilawar <badal.nilawar@intel.com>
Hi Badal,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-xe/drm-xe-next]
[also build test WARNING on char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus drm-i915/for-linux-next drm-i915/for-linux-next-fixes linus/master v6.16-rc3 next-20250623]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Badal-Nilawar/mei-bus-add-mei_cldev_mtu-interface/20250619-025825
base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link: https://lore.kernel.org/r/20250618190007.2932322-3-badal.nilawar%40intel.com
patch subject: [PATCH v3 02/10] mei: late_bind: add late binding component driver
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: i386-randconfig-141-20250623 (https://download.01.org/0day-ci/archive/20250624/202506241103.XiG3WA7g-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202506241103.XiG3WA7g-lkp@intel.com/
smatch warnings:
drivers/misc/mei/late_bind/mei_late_bind.c:203 mei_late_bind_component_match() warn: was && intended here instead of ||?
vim +203 drivers/misc/mei/late_bind/mei_late_bind.c
b4fe758cb831cd Alexander Usyskin 2025-06-19 170
b4fe758cb831cd Alexander Usyskin 2025-06-19 171 /**
b4fe758cb831cd Alexander Usyskin 2025-06-19 172 * mei_late_bind_component_match - compare function for matching mei late bind.
b4fe758cb831cd Alexander Usyskin 2025-06-19 173 *
b4fe758cb831cd Alexander Usyskin 2025-06-19 174 * The function checks if requested is Intel VGA device
b4fe758cb831cd Alexander Usyskin 2025-06-19 175 * and the parent of requester and the grand parent of mei_if are the same
b4fe758cb831cd Alexander Usyskin 2025-06-19 176 * device.
b4fe758cb831cd Alexander Usyskin 2025-06-19 177 *
b4fe758cb831cd Alexander Usyskin 2025-06-19 178 * @dev: master device
b4fe758cb831cd Alexander Usyskin 2025-06-19 179 * @subcomponent: subcomponent to match (I915_COMPONENT_LATE_BIND)
b4fe758cb831cd Alexander Usyskin 2025-06-19 180 * @data: compare data (mei late-bind bus device)
b4fe758cb831cd Alexander Usyskin 2025-06-19 181 *
b4fe758cb831cd Alexander Usyskin 2025-06-19 182 * Return:
b4fe758cb831cd Alexander Usyskin 2025-06-19 183 * * 1 - if components match
b4fe758cb831cd Alexander Usyskin 2025-06-19 184 * * 0 - otherwise
b4fe758cb831cd Alexander Usyskin 2025-06-19 185 */
b4fe758cb831cd Alexander Usyskin 2025-06-19 186 static int mei_late_bind_component_match(struct device *dev, int subcomponent,
b4fe758cb831cd Alexander Usyskin 2025-06-19 187 void *data)
b4fe758cb831cd Alexander Usyskin 2025-06-19 188 {
b4fe758cb831cd Alexander Usyskin 2025-06-19 189 struct device *base = data;
b4fe758cb831cd Alexander Usyskin 2025-06-19 190 struct pci_dev *pdev;
b4fe758cb831cd Alexander Usyskin 2025-06-19 191
b4fe758cb831cd Alexander Usyskin 2025-06-19 192 if (!dev)
b4fe758cb831cd Alexander Usyskin 2025-06-19 193 return 0;
b4fe758cb831cd Alexander Usyskin 2025-06-19 194
b4fe758cb831cd Alexander Usyskin 2025-06-19 195 if (!dev_is_pci(dev))
b4fe758cb831cd Alexander Usyskin 2025-06-19 196 return 0;
b4fe758cb831cd Alexander Usyskin 2025-06-19 197
b4fe758cb831cd Alexander Usyskin 2025-06-19 198 pdev = to_pci_dev(dev);
b4fe758cb831cd Alexander Usyskin 2025-06-19 199
b4fe758cb831cd Alexander Usyskin 2025-06-19 200 if (pdev->vendor != PCI_VENDOR_ID_INTEL)
b4fe758cb831cd Alexander Usyskin 2025-06-19 201 return 0;
b4fe758cb831cd Alexander Usyskin 2025-06-19 202
b4fe758cb831cd Alexander Usyskin 2025-06-19 @203 if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8) ||
b4fe758cb831cd Alexander Usyskin 2025-06-19 204 pdev->class != (PCI_CLASS_DISPLAY_OTHER << 8))
b4fe758cb831cd Alexander Usyskin 2025-06-19 205 return 0;
b4fe758cb831cd Alexander Usyskin 2025-06-19 206
b4fe758cb831cd Alexander Usyskin 2025-06-19 207 if (subcomponent != I915_COMPONENT_LATE_BIND)
b4fe758cb831cd Alexander Usyskin 2025-06-19 208 return 0;
b4fe758cb831cd Alexander Usyskin 2025-06-19 209
b4fe758cb831cd Alexander Usyskin 2025-06-19 210 base = base->parent;
b4fe758cb831cd Alexander Usyskin 2025-06-19 211 if (!base) /* mei device */
b4fe758cb831cd Alexander Usyskin 2025-06-19 212 return 0;
b4fe758cb831cd Alexander Usyskin 2025-06-19 213
b4fe758cb831cd Alexander Usyskin 2025-06-19 214 base = base->parent; /* pci device */
b4fe758cb831cd Alexander Usyskin 2025-06-19 215
b4fe758cb831cd Alexander Usyskin 2025-06-19 216 return !!base && dev == base;
b4fe758cb831cd Alexander Usyskin 2025-06-19 217 }
b4fe758cb831cd Alexander Usyskin 2025-06-19 218
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-06-24 3:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 3:14 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-06-18 18:59 [PATCH v3 00/10] Introducing firmware late binding Badal Nilawar
2025-06-18 18:59 ` [PATCH v3 02/10] mei: late_bind: add late binding component driver Badal Nilawar
2025-06-19 7:32 ` Gupta, Anshuman
2025-06-19 8:11 ` Jani Nikula
2025-06-19 9:06 ` Nilawar, Badal
2025-06-24 13:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506241103.XiG3WA7g-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.