Re: [PATCH net v4] ethernet: atl1: Add missing DMA mapping error checks

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 23 Jun 2025 11:20:41 +0200 Thomas Fourier wrote:
> + dma_err:
> +	while (first_mapped != next_to_use) {
> +		buffer_info = &tpd_ring->buffer_info[first_mapped];
> +		dma_unmap_page(&adapter->pdev->dev,
> +			       buffer_info->dma,
> +			       buffer_info->length,
> +			       DMA_TO_DEVICE);
> +		buffer_info->dma = 0;
> +
> +		if (++first_mapped == tpd_ring->count)
> +			first_mapped = 0;
> +	}
> +	return false;
>  }
>  
>  static void atl1_tx_queue(struct atl1_adapter *adapter, u16 count,
> @@ -2419,7 +2454,10 @@ static netdev_tx_t atl1_xmit_frame(struct sk_buff *skb,
>  		}
>  	}
>  
> -	atl1_tx_map(adapter, skb, ptpd);
> +	if (!atl1_tx_map(adapter, skb, ptpd)) {
> +		dev_kfree_skb_any(skb);
> +		return NETDEV_TX_OK;
> +	}

Code looks good but we need a counter for the drops.
Please add one in a similar way to the rx_dropped counter.
-- 
pw-bot: cr